Profile: redirect to /accounts/edit/ view on successful edit (#10610)

humitos · web-flow · commit bbb200ba2e42 · 2023-08-08T23:43:52.000+02:00
Closes #10404
diff --git a/readthedocs/profiles/views.py b/readthedocs/profiles/views.py
@@ -61,8 +61,7 @@ def get_object(self):
 
     def get_success_url(self):
         return reverse(
-            'profiles_profile_detail',
-            kwargs={'username': self.request.user.username},
+            "profiles_profile_edit",
         )
 
 
diff --git a/readthedocs/rtd_tests/tests/test_profile_views.py b/readthedocs/rtd_tests/tests/test_profile_views.py
@@ -36,6 +36,7 @@ def test_edit_profile(self):
             },
         )
         self.assertTrue(resp.status_code, 200)
+        self.assertEqual(resp["Location"], "/accounts/edit/")
 
         self.user.refresh_from_db()
         self.user.profile.refresh_from_db()

Original file line number	Diff line number	Diff line change
`@@ -61,8 +61,7 @@ def get_object(self):`
`61`	`61`
`62`	`62`	`def get_success_url(self):`
`63`	`63`	`return reverse(`
`64`		`- 'profiles_profile_detail',`
`65`		`- kwargs={'username': self.request.user.username},`
	`64`	`+ "profiles_profile_edit",`
`66`	`65`	`)`
`67`	`66`
`68`	`67`
Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,7 @@ def test_edit_profile(self):`
`36`	`36`	`},`
`37`	`37`	`)`
`38`	`38`	`self.assertTrue(resp.status_code, 200)`
	`39`	`+ self.assertEqual(resp["Location"], "/accounts/edit/")`
`39`	`40`
`40`	`41`	`self.user.refresh_from_db()`
`41`	`42`	`self.user.profile.refresh_from_db()`