Search: fix when searching an empty query (#10312)

Fixes #9969

Author: stsewd

readthedocs/search/tests/test_views.py

@@ -128,6 +128,15 @@ def test_search_no_owned_projects(self, client, all_projects):
         )
         assert len(results) == 0
 
+    def test_search_empty_query(self, client):
+        results, facets = self._get_search_result(
+            url=self.url,
+            client=client,
+            search_params={"q": "", "type": "project"},
+        )
+        assert results == []
+        assert facets == {}
+
 
 @pytest.mark.django_db
 @pytest.mark.search

readthedocs/search/views.py

@@ -136,8 +136,9 @@ def _search_projects(self, user_input, request):
                 projects=projects,
                 use_advanced_query=True,
             )
-            total_count = results.hits.total["value"]
-            results = ProjectSearchSerializer(results, many=True).data
+            if results:
+                total_count = results.hits.total["value"]
+                results = ProjectSearchSerializer(results, many=True).data
         context = user_input._asdict()
         context.update(
             {