Skip to content

Commit babf98e

Browse files
committed
use task.throws
1 parent 68ceee9 commit babf98e

File tree

2 files changed

+19
-4
lines changed

2 files changed

+19
-4
lines changed

readthedocs/projects/tasks.py

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@
6060
ProjectBuildsSkippedError,
6161
VersionLockedError,
6262
YAMLParseError,
63+
BuildEnvironmentWarning,
6364
)
6465
from readthedocs.doc_builder.loader import get_builder_class
6566
from readthedocs.doc_builder.python_environments import Conda, Virtualenv
@@ -272,7 +273,18 @@ def run(self, version_pk): # pylint: disable=arguments-differ
272273
return False
273274

274275

275-
@app.task(bind=True, max_retries=5, default_retry_delay=7 * 60)
276+
@app.task(
277+
bind=True,
278+
max_retries=5,
279+
default_retry_delay=7 * 60,
280+
throws=(
281+
VersionLockedError,
282+
ProjectBuildsSkippedError,
283+
YAMLParseError,
284+
BuildTimeoutError,
285+
ProjectBuildsSkippedError
286+
)
287+
)
276288
def update_docs_task(self, project_id, *args, **kwargs):
277289
step = UpdateDocsTaskStep(task=self)
278290
return step.run(project_id, *args, **kwargs)
@@ -1022,15 +1034,15 @@ def update_search(version_pk, commit, delete_non_commit_files=True):
10221034
)
10231035

10241036

1025-
@app.task(queue='web')
1037+
@app.task(queue='web', throws=(BuildEnvironmentWarning,))
10261038
def symlink_project(project_pk):
10271039
project = Project.objects.get(pk=project_pk)
10281040
for symlink in [PublicSymlink, PrivateSymlink]:
10291041
sym = symlink(project=project)
10301042
sym.run()
10311043

10321044

1033-
@app.task(queue='web')
1045+
@app.task(queue='web', throws=(BuildEnvironmentWarning,))
10341046
def symlink_domain(project_pk, domain_pk, delete=False):
10351047
project = Project.objects.get(pk=project_pk)
10361048
domain = Domain.objects.get(pk=domain_pk)
@@ -1070,7 +1082,7 @@ def broadcast_remove_orphan_symlinks():
10701082
broadcast(type='web', task=remove_orphan_symlinks, args=[])
10711083

10721084

1073-
@app.task(queue='web')
1085+
@app.task(queue='web', throws=(BuildEnvironmentWarning,))
10741086
def symlink_subproject(project_pk):
10751087
project = Project.objects.get(pk=project_pk)
10761088
for symlink in [PublicSymlink, PrivateSymlink]:

readthedocs/settings/base.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,9 @@ def USE_PROMOS(self): # noqa
266266
},
267267
}
268268

269+
# Sentry
270+
SENTRY_CELERY_IGNORE_EXPECTED = True
271+
269272
# Docker
270273
DOCKER_ENABLE = False
271274
DOCKER_IMAGE = 'readthedocs/build:2.0'

0 commit comments

Comments
 (0)