Add test

Author: stsewd

readthedocs/builds/models.py

@@ -322,11 +322,6 @@ def save(self, *args, **kwargs):  # pylint: disable=arguments-differ
             task=tasks.symlink_project,
             args=[self.project.pk],
         )
-
-        # These resources are not used when a version is inactive
-        if not self.active:
-            tasks.clean_project_resources(self.project, self)
-
         return obj
 
     def delete(self, *args, **kwargs):  # pylint: disable=arguments-differ

readthedocs/projects/views/private.py

@@ -203,6 +203,10 @@ def form_valid(self, form):
                     task=tasks.remove_dirs,
                     args=[version.get_artifact_paths()],
                 )
+                tasks.clean_project_resources(
+                    version.project,
+                    version,
+                )
                 version.built = False
                 version.save()
         return HttpResponseRedirect(self.get_success_url())

readthedocs/rtd_tests/tests/test_build_forms.py

@@ -1,6 +1,7 @@
-# -*- coding: utf-8 -*-
-
+import mock
+from django.contrib.auth.models import User
 from django.test import TestCase
+from django.urls import reverse
 from django_dynamic_fixture import get
 
 from readthedocs.builds.forms import VersionForm
@@ -12,7 +13,8 @@
 class TestVersionForm(TestCase):
 
     def setUp(self):
-        self.project = get(Project)
+        self.user = get(User)
+        self.project = get(Project, users=(self.user,))
 
     def test_default_version_is_active(self):
         version = get(
@@ -50,3 +52,35 @@ def test_default_version_is_inactive(self):
         )
         self.assertFalse(form.is_valid())
         self.assertIn('active', form.errors)
+
+    @mock.patch('readthedocs.projects.tasks.clean_project_resources')
+    def test_resources_are_deleted_when_version_is_inactive(self, clean_project_resources):
+        version = get(
+            Version,
+            project=self.project,
+            active=True,
+        )
+
+        url = reverse('project_version_detail', args=(version.project.slug, version.slug))
+
+        self.client.force_login(self.user)
+
+        r = self.client.post(
+            url,
+            data={
+                'active': True,
+                'privacy_level': PRIVATE,
+            },
+        )
+        self.assertTrue(r.status_code, 200)
+        clean_project_resources.assert_not_called()
+
+        r = self.client.post(
+            url,
+            data={
+                'active': False,
+                'privacy_level': PRIVATE,
+            },
+        )
+        self.assertTrue(r.status_code, 200)
+        clean_project_resources.assert_called_once()