Test case for duplicated BuildCommandResult

Author: humitos

readthedocs/api/v2/views/model_views.py

@@ -337,9 +337,12 @@ def perform_create(self, serializer):
         if not build_api_key.project.builds.filter(pk=build_pk).exists():
             raise PermissionDenied()
 
-        if BuildCommandResult.objects.filter(**serializer.validated_data).exists():
+        if BuildCommandResult.objects.filter(
+            build=serializer.validated_data["build"],
+            command=serializer.validated_data["command"],
+        ).exists():
             log.warning("Build command is duplicated. Skipping...")
-            return Response(status=status.HTTP_204_NO_CONTENT)
+            return
 
         return super().perform_create(serializer)
 

readthedocs/rtd_tests/tests/test_api.py

@@ -909,6 +909,48 @@ def test_build_read_and_write_endpoints_for_build_api_token(self):
             resp = client.patch(f"/api/v2/build/{build.pk}/")
             self.assertEqual(resp.status_code, 404)
 
+    def test_build_commands_duplicated_command(self):
+        """Sending the same request twice should only create one BuildCommandResult."""
+        project = get(
+            Project,
+            language="en",
+        )
+        version = project.versions.first()
+        build = Build.objects.create(project=project, version=version)
+
+        self.assertEqual(BuildCommandResult.objects.count(), 0)
+
+        client = APIClient()
+        _, build_api_key = BuildAPIKey.objects.create_key(project)
+        client.credentials(HTTP_AUTHORIZATION=f"Token {build_api_key}")
+
+        now = timezone.now()
+        start_time = now - datetime.timedelta(seconds=5)
+        end_time = now
+
+        data = {
+            "build": build.pk,
+            "command": "git status",
+            "description": "Git status",
+            "exit_code": 0,
+            "start_time": start_time,
+            "end_time": end_time,
+        }
+
+        response = client.post(
+            "/api/v2/command/",
+            data,
+            format="json",
+        )
+        self.assertEqual(response.status_code, 201)
+        response = client.post(
+            "/api/v2/command/",
+            data,
+            format="json",
+        )
+        self.assertEqual(response.status_code, 201)
+        self.assertEqual(BuildCommandResult.objects.count(), 1)
+
     def test_build_commands_read_only_endpoints_for_normal_user(self):
         user_normal = get(User, is_staff=False)
         user_admin = get(User, is_staff=True)