Managers used in all the places

Author: saadmk11

readthedocs/api/v3/views.py

@@ -269,7 +269,7 @@ class BuildsViewSet(APIv3Settings, NestedViewSetMixin, ProjectQuerySetMixin,
     lookup_url_kwarg = 'build_pk'
     serializer_class = BuildSerializer
     filterset_class = BuildFilter
-    queryset = Build.objects.all()
+    queryset = Build.internal.all()
     permit_list_expands = [
         'config',
     ]

readthedocs/builds/models.py

@@ -207,7 +207,7 @@ def config(self):
         :rtype: dict
         """
         last_build = (
-            self.builds.filter(
+            self.builds(manager=INTERNAL).filter(
                 state='finished',
                 success=True,
             ).order_by('-date').first()
@@ -662,7 +662,7 @@ def previous(self):
         date = self.date or timezone.now()
         if self.project is not None and self.version is not None:
             return (
-                Build.objects.filter(
+                Build.internal.filter(
                     project=self.project,
                     version=self.version,
                     date__lt=date,

readthedocs/builds/views.py

@@ -84,6 +84,21 @@ def post(self, request, project_slug):
 
 class BuildList(BuildBase, BuildTriggerMixin, ListView):
 
+    def get_queryset(self):
+        # this is used to include only internal version
+        # builds in the build list page
+        self.project_slug = self.kwargs.get('project_slug', None)
+        self.project = get_object_or_404(
+            Project.objects.protected(self.request.user),
+            slug=self.project_slug,
+        )
+        queryset = Build.internal.public(
+            user=self.request.user,
+            project=self.project,
+        ).select_related('project', 'version')
+
+        return queryset
+
     def get_context_data(self, **kwargs):
         context = super().get_context_data(**kwargs)
 

readthedocs/core/templatetags/privacy_tags.py

@@ -26,7 +26,7 @@ def get_public_projects(context, user):
         viewer=context['request'].user,
     ).prefetch_latest_build().annotate(
         _good_build=Exists(
-            Build.objects.filter(success=True, project=OuterRef('pk')))
+            Build.internal.filter(success=True, project=OuterRef('pk')))
     )
     context['public_projects'] = projects
     return ''

readthedocs/projects/models.py

@@ -768,7 +768,7 @@ def has_good_build(self):
         # Used for Database optimization.
         if hasattr(self, '_good_build'):
             return self._good_build
-        return self.builds.filter(success=True).exists()
+        return self.builds(manager=INTERNAL).filter(success=True).exists()
 
     @property
     def has_versions(self):

readthedocs/projects/querysets.py

@@ -85,13 +85,13 @@ def prefetch_latest_build(self):
 
         # Prefetch the latest build for each project.
         subquery = Subquery(
-            Build.objects.filter(
+            Build.internal.filter(
                 project=OuterRef('project_id')
             ).order_by('-date').values_list('id', flat=True)[:1]
         )
         latest_build = Prefetch(
             'builds',
-            Build.objects.filter(pk__in=subquery),
+            Build.internal.filter(pk__in=subquery),
             to_attr=self.model.LATEST_BUILD_CACHE,
         )
         return self.prefetch_related(latest_build)