Skip to content

Commit ac6c81d

Browse files
committed
Don't display the build suggestions div if there are no suggestions
This added extraneous spacing to the build page.
1 parent c8a72f5 commit ac6c81d

File tree

1 file changed

+20
-20
lines changed

1 file changed

+20
-20
lines changed

readthedocs/templates/builds/build_detail.html

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -92,28 +92,28 @@
9292
</span>
9393
</div>
9494

95-
<div class="build-ideas">
9695
{% if not build.success and build.commands.count < 4 %}
97-
<p>
98-
99-
{% url 'wipe_version' build.version.project.slug build.version.slug as wipe_url %}
100-
{% blocktrans %}
101-
Having trouble with your build environment?
102-
Try <a href="{{ wipe_url }}">reseting it</a>.
103-
{% endblocktrans %}
104-
</p>
105-
{% endif %}
106-
107-
{% if not build.success and "setup.py install" in build.commands.last.output %}
108-
<p>
109-
{% url 'projects_advanced' build.version.project.slug as advanced_url %}
110-
{% blocktrans %}
111-
Don't want <pre>setup.py install</pre> called?
112-
Change the <strong>Install Project</strong> setting in your <a href="{{ advanced_url }}">advanced settings</a>.
113-
{% endblocktrans %}
114-
</p>
96+
<div class="build-ideas">
97+
<p>
98+
99+
{% url 'wipe_version' build.version.project.slug build.version.slug as wipe_url %}
100+
{% blocktrans %}
101+
Having trouble with your build environment?
102+
Try <a href="{{ wipe_url }}">reseting it</a>.
103+
{% endblocktrans %}
104+
</p>
105+
</div>
106+
{% elif not build.success and "setup.py install" in build.commands.last.output %}
107+
<div class="build-ideas">
108+
<p>
109+
{% url 'projects_advanced' build.version.project.slug as advanced_url %}
110+
{% blocktrans %}
111+
Don't want <pre>setup.py install</pre> called?
112+
Change the <strong>Install Project</strong> setting in your <a href="{{ advanced_url }}">advanced settings</a>.
113+
{% endblocktrans %}
114+
</p>
115+
</div>
115116
{% endif %}
116-
</div>
117117

118118
{% if build.output %}
119119
{# If we have build output, this is an old build #}

0 commit comments

Comments
 (0)