Revert "Add support for successful build prefetch (#11613)"

This reverts commit a6e1fde.

Author: agjohnson

readthedocs/projects/models.py

@@ -575,7 +575,6 @@ class Project(models.Model):
 
     # Property used for storing the latest build for a project when prefetching
     LATEST_BUILD_CACHE = "_latest_build"
-    LATEST_SUCCESSFUL_BUILD_CACHE = "_latest_successful_build"
 
     class Meta:
         ordering = ("slug",)
@@ -921,13 +920,6 @@ def conf_dir(self, version=LATEST):
 
     @property
     def has_good_build(self):
-        # Check if there is `_latest_successful_build` attribute in the Queryset.
-        # Used for database optimization.
-        if hasattr(self, self.LATEST_SUCCESSFUL_BUILD_CACHE):
-            if build_successful := getattr(self, self.LATEST_SUCCESSFUL_BUILD_CACHE):
-                return build_successful[0]
-            return None
-
         # Check if there is `_good_build` annotation in the Queryset.
         # Used for Database optimization.
         if hasattr(self, "_good_build"):

readthedocs/projects/querysets.py

@@ -132,33 +132,17 @@ def prefetch_latest_build(self):
         from readthedocs.builds.models import Build
 
         # Prefetch the latest build for each project.
-        subquery_build_latest = Subquery(
+        subquery = Subquery(
             Build.internal.filter(project=OuterRef("project_id"))
             .order_by("-date")
             .values_list("id", flat=True)[:1]
         )
-        prefetch_build_latest = Prefetch(
+        latest_build = Prefetch(
             "builds",
-            Build.internal.filter(pk__in=subquery_build_latest),
+            Build.internal.filter(pk__in=subquery),
             to_attr=self.model.LATEST_BUILD_CACHE,
         )
-
-        # Prefetch the latest successful build for each project.
-        subquery_build_successful = Subquery(
-            Build.internal.filter(project=OuterRef("project_id"))
-            .order_by("-date")
-            .values_list("id", flat=True)[:1]
-        )
-        prefetch_build_successful = Prefetch(
-            "builds",
-            Build.internal.filter(pk__in=subquery_build_successful),
-            to_attr=self.model.LATEST_SUCCESSFUL_BUILD_CACHE,
-        )
-
-        return self.prefetch_related(
-            prefetch_build_latest,
-            prefetch_build_successful,
-        )
+        return self.prefetch_related(latest_build)
 
     # Aliases