Skip to content

Commit a6fa012

Browse files
authored
Merge pull request #4375 from rtfd/humitos/sentry/tags
More tags when logging errors to Sentry
2 parents 9abfc04 + 59dcd76 commit a6fa012

File tree

2 files changed

+31
-5
lines changed

2 files changed

+31
-5
lines changed

readthedocs/doc_builder/environments.py

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,15 @@ def handle_exception(self, exc_type, exc_value, _):
450450
.format(project=self.project.slug,
451451
version=self.version.slug,
452452
msg=exc_value),
453-
exc_info=True)
453+
exc_info=True,
454+
extra={
455+
'stack': True,
456+
'tags': {
457+
'build': self.build.get('id'),
458+
'project': self.project.slug,
459+
'version': self.version.slug,
460+
},
461+
})
454462
self.failure = exc_value
455463
return True
456464

@@ -546,8 +554,12 @@ def update_build(self, state=None):
546554
str(self.failure),
547555
extra={
548556
'stack': True,
549-
'tags': {'build': self.build['id']},
550-
}
557+
'tags': {
558+
'build': self.build.get('id'),
559+
'project': self.project.slug,
560+
'version': self.version.slug,
561+
},
562+
},
551563
)
552564
self.failure = BuildEnvironmentError(
553565
BuildEnvironmentError.GENERIC_WITH_BUILD_ID.format(

readthedocs/projects/tasks.py

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,14 @@ def run(self, pk, version_pk=None, build_pk=None, record=True,
346346
except Exception as e: # noqa
347347
log.exception(
348348
'An unhandled exception was raised during build setup',
349-
extra={'tags': {'build': build_pk}}
349+
extra={
350+
'stack': True,
351+
'tags': {
352+
'build': build_pk,
353+
'project': self.project.slug,
354+
'version': self.version.slug,
355+
},
356+
},
350357
)
351358
self.setup_env.failure = BuildEnvironmentError(
352359
BuildEnvironmentError.GENERIC_WITH_BUILD_ID.format(
@@ -363,7 +370,14 @@ def run(self, pk, version_pk=None, build_pk=None, record=True,
363370
except Exception as e: # noqa
364371
log.exception(
365372
'An unhandled exception was raised during project build',
366-
extra={'tags': {'build': build_pk}}
373+
extra={
374+
'stack': True,
375+
'tags': {
376+
'build': build_pk,
377+
'project': self.project.slug,
378+
'version': self.version.slug,
379+
},
380+
},
367381
)
368382
self.build_env.failure = BuildEnvironmentError(
369383
BuildEnvironmentError.GENERIC_WITH_BUILD_ID.format(

0 commit comments

Comments
 (0)