Get features from the footer api

Author: stsewd

readthedocs/api/v2/views/footer_views.py

@@ -15,7 +15,7 @@
 from readthedocs.builds.constants import LATEST, TAG
 from readthedocs.builds.models import Version
 from readthedocs.core.utils.extend import SettingsOverrideObject
-from readthedocs.projects.models import Project
+from readthedocs.projects.models import Project, Feature
 from readthedocs.projects.version_handling import (
     highest_version,
     parse_version_failsafe,
@@ -199,6 +199,19 @@ def _get_context(self):
         }
         return context
 
+    def _get_features(self):
+        project = self._get_project()
+        version = self._get_version()
+
+        docsearch_disabled = project.has_feature(Feature.DISABLE_SERVER_SIDE_SEARCH)
+        if not version.is_sphinx_type:
+            # TODO: Temporal check
+            docsearch_disabled |= not self.project.has_feature(Feature.ENABLE_MKDOCS_SERVER_SIDE_SEARCH)
+
+        return {
+            'docsearch_disabled': docsearch_disabled,
+        }
+
     def get(self, request, format=None):
         project = self._get_project()
         version = self._get_version()
@@ -219,6 +232,7 @@ def get(self, request, format=None):
             'version_active': version.active,
             'version_compare': version_compare_data,
             'version_supported': version.supported,
+            'features': self._get_features(),
         }
 
         # Allow folks to hook onto the footer response for various information

readthedocs/core/static-src/core/js/doc-embed/footer.js

@@ -22,6 +22,13 @@ function injectFooter(data) {
 }
 
 
+function injectExtraData(data) {
+  if (typeof window.READTHEDOCS_DATA !=== 'undefined') {
+      window.READTHEDOCS_DATA.features = data['features'];
+  }
+}
+
+
 function setupBookmarkCSRFToken() {
     function csrfSafeMethod(method) {
         // these HTTP methods do not require CSRF protection
@@ -76,6 +83,7 @@ function init() {
                 versionCompare.init(data.version_compare);
             }
             injectFooter(data);
+            injectExtraData(data);
             setupBookmarkCSRFToken();
         },
         error: function () {

readthedocs/doc_builder/backends/mkdocs.py

@@ -253,12 +253,6 @@ def generate_rtd_data(self, docs_dir, mkdocs_config):
             'commit': self.version.project.vcs_repo(self.version.slug).commit,
             'global_analytics_code': settings.GLOBAL_ANALYTICS_CODE,
             'user_analytics_code': analytics_code,
-            'features': {
-                'docsearch_disabled': (
-                    self.project.has_feature(Feature.DISABLE_SERVER_SIDE_SEARCH)
-                    and not self.project.has_feature(Feature.ENABLE_MKDOCS_SERVER_SIDE_SEARCH)
-                )
-            },
         }
 
         data_ctx = {

readthedocs/doc_builder/backends/sphinx.py

@@ -181,7 +181,6 @@ def get_config_params(self):
             'dont_overwrite_sphinx_context': self.project.has_feature(
                 Feature.DONT_OVERWRITE_SPHINX_CONTEXT,
             ),
-            'docsearch_disabled': self.project.has_feature(Feature.DISABLE_SERVER_SIDE_SEARCH),
         }
 
         finalize_sphinx_context_data.send(

readthedocs/doc_builder/templates/doc_builder/conf.py.tmpl

@@ -113,7 +113,6 @@ context = {
     'new_theme': (html_theme == "sphinx_rtd_theme"),
     'source_suffix': SUFFIX,
     'ad_free': {% if project.show_advertising %}False{% else %}True{% endif %},
-    'docsearch_disabled': {{ docsearch_disabled }},
     'user_analytics_code': '{{ project.analytics_code|default_if_none:'' }}',
     'global_analytics_code': '{{ settings.GLOBAL_ANALYTICS_CODE }}',
     'commit': {% if project.repo_type == 'git' %}'{{ commit|slice:"8" }}'{% else %}'{{ commit }}'{% endif %},