Add test for building by commit

Author: ericholscher

readthedocs/builds/views.py

@@ -58,7 +58,8 @@ def post(self, request, project_slug):
         build_pk = request.POST.get('build_pk')
 
         version = get_object_or_404(
-            self._get_versions(project),
+            # Don't filter by internal/external here so we can build all versions
+            Version.objects.public(self.request.user),
             slug=version_slug,
         )
 

readthedocs/rtd_tests/tests/test_views.py

@@ -263,6 +263,22 @@ def test_build_list_includes_external_versions(self):
         self.assertEqual(response.status_code, 200)
         self.assertIn(external_version_build, response.context['build_qs'])
 
+    @mock.patch('readthedocs.projects.tasks.update_docs_task')
+    def test_build_commit_external_version(self, mock):
+        ver = self.pip.versions.first()
+        ver.commit = 'asd324653546'
+        ver.type = 'external'
+        ver.save()
+        build = get(Build, version=ver, project=self.pip)
+        build.save()
+        r = self.client.post('/projects/pip/builds/',
+            {'version_slug': ver.slug, 'commit': ver.commit, 'build_pk': build.pk}
+        )
+        self.assertEqual(r.status_code, 302)
+        self.assertEqual(
+            r._headers['location'][1],
+            '/projects/pip/builds/%s/' % build.pk,
+        )
 
 class TestSearchAnalyticsView(TestCase):