Skip to content

Commit 9cce254

Browse files
committed
Upgrade django-filter
1 parent 658bb07 commit 9cce254

File tree

2 files changed

+1
-13
lines changed

2 files changed

+1
-13
lines changed

readthedocs/restapi/views/model_views.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,6 @@ class ProjectViewSet(UserSelectViewSet):
105105
admin_serializer_class = ProjectAdminSerializer
106106
model = Project
107107
pagination_class = api_utils.ProjectPagination
108-
filter_fields = ('slug',) # django-filter<2.0.0
109108
filterset_fields = ('slug',)
110109

111110
@decorators.action(detail=True)
@@ -250,10 +249,6 @@ class VersionViewSet(UserSelectViewSet):
250249
serializer_class = VersionSerializer
251250
admin_serializer_class = VersionAdminSerializer
252251
model = Version
253-
filter_fields = (
254-
'active',
255-
'project__slug',
256-
) # django-filter<2.0.0
257252
filterset_fields = (
258253
'active',
259254
'project__slug',
@@ -266,7 +261,6 @@ class BuildViewSetBase(UserSelectViewSet):
266261
serializer_class = BuildSerializer
267262
admin_serializer_class = BuildAdminSerializer
268263
model = Build
269-
filter_fields = ('project__slug', 'commit') # django-filter<2.0.0
270264
filterset_fields = ('project__slug', 'commit')
271265

272266

requirements/pip.txt

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,7 @@ django-extensions==2.1.4
1111
djangorestframework==3.9.1
1212

1313
# Filtering for the REST API
14-
# When Python2 gets deprecated we can upgrade django-filter
15-
# > from .filterset import FilterSet
16-
# E File "/home/travis/build/rtfd/readthedocs.org/.tox/py27/lib/python2.7/site-packages/django_filters/filterset.py", line 184
17-
# E def __init__(self, data=None, queryset=None, *, request=None, prefix=None):
18-
# E ^
19-
# E SyntaxError: invalid syntax
20-
django-filter<2.0.0
14+
django-filter==2.1.0
2115

2216
django-vanilla-views==1.0.6
2317
jsonfield==2.0.2

0 commit comments

Comments
 (0)