Merge pull request #8943 from readthedocs/humitos/reset-build-error

Build: reset build error before start building

Author: humitos

readthedocs/projects/tasks/builds.py

@@ -329,6 +329,9 @@ def before_start(self, task_id, args, kwargs):
         # Save the builder instance's name into the build object
         self.data.build['builder'] = socket.gethostname()
 
+        # Reset any previous build error reported to the user
+        self.data.build['error'] = ''
+
         # Also note there are builds that are triggered without a commit
         # because they just build the latest commit for that version
         self.data.build_commit = kwargs.get('build_commit')

readthedocs/projects/tests/test_build_tasks.py

@@ -283,6 +283,7 @@ def test_successful_build(self, load_yaml_config, clean_build, send_notification
             'id': 1,
             'state': 'cloning',
             'commit': 'a1b2c3',
+            'error': '',
             'builder': mock.ANY,
         }
 
@@ -331,6 +332,7 @@ def test_successful_build(self, load_yaml_config, clean_build, send_notification
             'commit': 'a1b2c3',
             'config': mock.ANY,
             'builder': mock.ANY,
+            'error': '',
         }
         # Update build state: building
         assert self.requests_mock.request_history[6].json() == {
@@ -339,6 +341,7 @@ def test_successful_build(self, load_yaml_config, clean_build, send_notification
             'commit': 'a1b2c3',
             'config': mock.ANY,
             'builder': mock.ANY,
+            'error': '',
         }
         # Update build state: uploading
         assert self.requests_mock.request_history[7].json() == {
@@ -347,6 +350,7 @@ def test_successful_build(self, load_yaml_config, clean_build, send_notification
             'commit': 'a1b2c3',
             'config': mock.ANY,
             'builder': mock.ANY,
+            'error': '',
         }
         # Update version state
         assert self.requests_mock.request_history[8]._request.method == 'PATCH'
@@ -371,6 +375,7 @@ def test_successful_build(self, load_yaml_config, clean_build, send_notification
             'builder': mock.ANY,
             'length': mock.ANY,
             'success': True,
+            'error': '',
         }
 
         self.mocker.mocks['build_media_storage'].sync_directory.assert_has_calls([