Skip to content

Commit 9a44723

Browse files
committed
Remove global pip cache
This is not working anymore and it can be superseded by a docker container with devpi instead.
1 parent 33e649f commit 9a44723

File tree

3 files changed

+0
-14
lines changed

3 files changed

+0
-14
lines changed

readthedocs/doc_builder/environments.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -945,9 +945,6 @@ def _get_binds(self):
945945
946946
It uses Docker Volume if running on a docker-compose. Otherwise, it
947947
returns just a regular mountpoint path.
948-
949-
Besides, it binds the ``GLOBAL_PIP_CACHE`` if it's set and we are under
950-
``DEBUG`` mode.
951948
"""
952949
if getattr(settings, 'RTD_DOCKER_COMPOSE', False):
953950
from pathlib import Path
@@ -965,14 +962,6 @@ def _get_binds(self):
965962
},
966963
}
967964

968-
if settings.GLOBAL_PIP_CACHE and settings.DEBUG:
969-
binds.update({
970-
self.project.pip_cache_path: {
971-
'bind': self.project.pip_cache_path,
972-
'mode': 'rw',
973-
},
974-
})
975-
976965
return binds
977966

978967
def get_container_host_config(self):

readthedocs/projects/models.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -663,8 +663,6 @@ def checkout_path(self, version=LATEST):
663663
@property
664664
def pip_cache_path(self):
665665
"""Path to pip cache."""
666-
if settings.GLOBAL_PIP_CACHE and settings.DEBUG:
667-
return settings.GLOBAL_PIP_CACHE
668666
return os.path.join(self.doc_path, '.cache', 'pip')
669667

670668
#

readthedocs/settings/base.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,6 @@ def USE_PROMOS(self): # noqa
275275
}
276276
}
277277
CACHE_MIDDLEWARE_SECONDS = 60
278-
GLOBAL_PIP_CACHE = False
279278

280279
# I18n
281280
TIME_ZONE = 'UTC'

0 commit comments

Comments
 (0)