Skip to content

Commit 98a7ff1

Browse files
authored
Merge pull request #6142 from readthedocs/fix-search-saving
Serialize time in search queries properly
2 parents 557c875 + b766388 commit 98a7ff1

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

readthedocs/search/api.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ def list(self, request, *args, **kwargs):
173173
version_slug,
174174
query,
175175
total_results,
176-
time,
176+
time.isoformat(),
177177
)
178178

179179
return response

readthedocs/search/tasks.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import logging
22

3+
from dateutil.parser import parse
34
from django.apps import apps
45
from django.utils import timezone
56
from django_elasticsearch_dsl.registries import registry
@@ -142,17 +143,18 @@ def delete_old_search_queries_from_db():
142143

143144

144145
@app.task(queue='web')
145-
def record_search_query(project_slug, version_slug, query, total_results, time):
146+
def record_search_query(project_slug, version_slug, query, total_results, time_string):
146147
"""Record/update search query in database."""
147148
if not project_slug or not version_slug or not query:
148149
log.debug(
149150
'Not recording the search query. Passed arguments: '
150151
'project_slug: %s, version_slug: %s, query: %s, total_results: %s, time: %s' % (
151-
project_slug, version_slug, query, total_results, time
152+
project_slug, version_slug, query, total_results, time_string
152153
)
153154
)
154155
return
155156

157+
time = parse(time_string)
156158
before_10_sec = time - timezone.timedelta(seconds=10)
157159
partial_query_qs = SearchQuery.objects.filter(
158160
project__slug=project_slug,

0 commit comments

Comments
 (0)