Skip to content

Commit 8f2239a

Browse files
committed
Always run CoreTagsTests with http
This is to make some tests pass in .com. We only uses subdomains on .com, so this setting is always http for .org
1 parent 50c63f7 commit 8f2239a

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

readthedocs/conftest.py

-7
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
('community', True),
1515
('corporate', False),
1616
('environment', 'readthedocs'),
17-
18-
('url_scheme', 'http'),
1917
)
2018

2119

@@ -50,8 +48,3 @@ def settings_modification(settings):
5048
@pytest.fixture
5149
def api_client():
5250
return APIClient()
53-
54-
55-
@pytest.fixture(scope="class")
56-
def url_scheme(request):
57-
request.cls.url_scheme = request.config.option.url_scheme

readthedocs/rtd_tests/tests/test_core_tags.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,12 @@
99
from readthedocs.projects.models import Project
1010

1111

12-
@pytest.mark.usefixtures("url_scheme")
1312
@override_settings(USE_SUBDOMAIN=False, PRODUCTION_DOMAIN='readthedocs.org')
1413
class CoreTagsTests(TestCase):
1514
fixtures = ['eric', 'test_data']
1615

1716
def setUp(self):
18-
url_base = '{scheme}://{domain}/docs/pip{{version}}'.format(
19-
scheme=self.url_scheme,
17+
url_base = 'http://{domain}/docs/pip{{version}}'.format(
2018
domain=settings.PRODUCTION_DOMAIN,
2119
)
2220

0 commit comments

Comments
 (0)