Validate that name does not contain spaces on it

Author: humitos

readthedocs/projects/forms.py

@@ -796,4 +796,8 @@ def clean_name(self):
             raise forms.ValidationError(
                 _('There is already a variable with this name for this project'),
             )
+        elif ' ' in name:
+            raise forms.ValidationError(
+                _("Variable name can't contain spaces"),
+            )
         return name

readthedocs/rtd_tests/tests/test_project_forms.py

@@ -487,6 +487,17 @@ def setUp(self):
         self.project = get(Project)
 
     def test_use_invalid_names(self):
+        data = {
+            'name': 'VARIABLE WITH SPACES',
+            'value': 'string here',
+        }
+        form = EnvironmentVariableForm(data, project=self.project)
+        self.assertFalse(form.is_valid())
+        self.assertIn(
+            "Variable name can't contain spaces",
+            form.errors['name'],
+        )
+
         data = {
             'name': 'READTHEDOCS__INVALID',
             'value': 'string here',
@@ -497,6 +508,7 @@ def test_use_invalid_names(self):
             "Variable name can't start with READTHEDOCS",
             form.errors['name'],
         )
+
         data = {
             'name': '__INVALID',
             'value': 'string here',