Validate with a regex for valid chars

Author: humitos

readthedocs/projects/forms.py

@@ -9,6 +9,7 @@
     unicode_literals,
 )
 
+import re
 from random import choice
 
 from builtins import object
@@ -800,4 +801,8 @@ def clean_name(self):
             raise forms.ValidationError(
                 _("Variable name can't contain spaces"),
             )
+        elif not re.fullmatch('[a-zA-Z0-9_]+', name):
+            raise forms.ValidationError(
+                _('Only letters, numbers and underscore are allowed'),
+            )
         return name

readthedocs/rtd_tests/tests/test_project_forms.py

@@ -509,6 +509,17 @@ def test_use_invalid_names(self):
             form.errors['name'],
         )
 
+        data = {
+            'name': 'INVALID_CHAR*',
+            'value': 'string here',
+        }
+        form = EnvironmentVariableForm(data, project=self.project)
+        self.assertFalse(form.is_valid())
+        self.assertIn(
+            'Only letters, numbers and underscore are allowed',
+            form.errors['name'],
+        )
+
         data = {
             'name': '__INVALID',
             'value': 'string here',