Skip to content

Commit 88beea8

Browse files
committed
Rewrite generators based on feedback from Twitter
https://twitter.com/scaramagus/status/1085668552789708801
1 parent 0ed9952 commit 88beea8

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

readthedocs/core/views/serve.py

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
from __future__ import (
2929
absolute_import, division, print_function, unicode_literals)
3030

31+
import itertools
3132
import logging
3233
import mimetypes
3334
import os
@@ -287,11 +288,7 @@ def priorities_generator():
287288
iteration. After 0.1 is reached, it will keep returning 0.1.
288289
"""
289290
priorities = [1, 0.9, 0.8, 0.7, 0.6, 0.5, 0.4, 0.3, 0.2]
290-
for p in priorities:
291-
yield p
292-
293-
while True:
294-
yield 0.1
291+
yield itertools.chain(priorities, itertools.repeat(0.1))
295292

296293
def changefreqs_generator():
297294
"""
@@ -301,11 +298,7 @@ def changefreqs_generator():
301298
will return always ``monthly``.
302299
"""
303300
changefreqs = ['daily', 'weekly']
304-
for c in changefreqs:
305-
yield c
306-
307-
while True:
308-
yield 'monthly'
301+
yield itertools.chain(changefreqs, itertools.repeat('monthly'))
309302

310303
sorted_versions = sort_version_aware(project.versions.filter(active=True))
311304

0 commit comments

Comments
 (0)