Merge pull request #6869 from readthedocs/list-subprojects-fix

Don't do unnecessary queries when listing subprojects

Author: stsewd

readthedocs/projects/views/private.py

@@ -2,6 +2,7 @@
 
 import csv
 import logging
+from urllib.parse import urlparse
 
 from allauth.socialaccount.models import SocialAccount
 from django.conf import settings
@@ -44,6 +45,7 @@
     LoginRequiredMixin,
     PrivateViewMixin,
 )
+from readthedocs.core.resolver import resolve, resolve_path
 from readthedocs.core.utils import broadcast, trigger_build
 from readthedocs.core.utils.extend import SettingsOverrideObject
 from readthedocs.integrations.models import HttpExchange, Integration
@@ -462,8 +464,36 @@ class ProjectRelationshipList(ProjectRelationshipMixin, ListView):
     def get_context_data(self, **kwargs):
         ctx = super().get_context_data(**kwargs)
         ctx['superproject'] = self.project.superprojects.first()
+        ctx['subprojects_and_urls'] = self.get_subprojects_and_urls()
         return ctx
 
+    def get_subprojects_and_urls(self):
+        """
+        Get a tuple of subprojects and its absolute URls.
+
+        All subprojects share the domain from the parent,
+        so instead of resolving the domain and path for each subproject,
+        we resolve only the path of each one.
+        """
+        subprojects_and_urls = []
+
+        main_domain = resolve(self.project)
+        parsed_main_domain = urlparse(main_domain)
+
+        subprojects = self.object_list.select_related('child')
+        for subproject in subprojects:
+            subproject_path = resolve_path(subproject.child)
+            parsed_subproject_domain = parsed_main_domain._replace(
+                path=subproject_path,
+            )
+            subprojects_and_urls.append(
+                (
+                    subproject,
+                    parsed_subproject_domain.geturl(),
+                )
+            )
+        return subprojects_and_urls
+
 
 class ProjectRelationshipCreate(ProjectRelationshipMixin, CreateView):
 

readthedocs/templates/projects/projectrelationship_list.html

@@ -48,7 +48,7 @@
       <div class="module-list">
         <div class="module-list-wrapper">
           <ul class="subprojects">
-            {% for subproject in object_list %}
+            {% for subproject, absolute_url in subprojects_and_urls %}
               <li class="module-item subproject">
                 <div class="module-title">
                   <a
@@ -58,8 +58,8 @@
                   </a>
                   <span>
                     <a class="module-info subproject-url"
-                      href="{{ subproject.get_absolute_url }}">
-                      {{ subproject.get_absolute_url }}
+                      href="{{ absolute_url }}">
+                      {{ absolute_url }}
                     </a>
                   </span>
                 </div>