lint fix

Author: saadmk11

readthedocs/builds/models.py

@@ -70,6 +70,7 @@
     get_gitlab_username_repo,
 )
 from readthedocs.builds.version_slug import VersionSlugField
+from readthedocs.oauth.models import RemoteRepository
 
 
 log = logging.getLogger(__name__)
@@ -779,7 +780,7 @@ def get_commit_url(self):
                     repo=repo,
                     commit=self.commit
                 )
-            elif 'gitlab' in repo_url:
+            if 'gitlab' in repo_url:
                 user, repo = get_gitlab_username_repo(repo_url)
                 if not user and not repo:
                     return ''
@@ -790,7 +791,7 @@ def get_commit_url(self):
                     repo=repo,
                     commit=self.commit
                 )
-            elif 'bitbucket' in repo_url:
+            if 'bitbucket' in repo_url:
                 user, repo = get_bitbucket_username_repo(repo_url)
                 if not user and not repo:
                     return ''
@@ -801,8 +802,6 @@ def get_commit_url(self):
                     repo=repo,
                     commit=self.commit
                 )
-            else:
-                log.info('Unknown Git provider for %s', self.project)
 
         return ''
 

readthedocs/rtd_tests/tests/test_version.py

@@ -46,7 +46,7 @@ def setUp(self):
 class TestVersionModel(VersionMixin, TestCase):
 
     def test_vcs_url_for_external_version(self):
-        expected_url = f'https://github.com/pypa/pip/pull/{self.external_version.verbose_name}/'
+        expected_url = f'https://github.com/pypa/pip/pull/{self.external_version.verbose_name}'
         self.assertEqual(self.external_version.vcs_url, expected_url)
 
     def test_vcs_url_for_latest_version(self):