Constant name updated

Author: saadmk11

readthedocs/builds/models.py

@@ -22,7 +22,7 @@
 from readthedocs.projects.constants import (
     BITBUCKET_COMMIT_URL,
     BITBUCKET_URL,
-    GITHUB,
+    GITHUB_BRAND,
     GITHUB_COMMIT_URL,
     GITHUB_URL,
     GITHUB_PULL_REQUEST_URL,
@@ -838,7 +838,7 @@ def is_external(self):
     @property
     def external_version_name(self):
         if self.is_external:
-            if self.project.git_provider_name == GITHUB:
+            if self.project.git_provider_name == GITHUB_BRAND:
                 return GITHUB_EXTERNAL_VERSION_NAME
             # TODO: Add External Version Name for other Git Providers
 

readthedocs/projects/constants.py

@@ -357,4 +357,4 @@
 GITHUB_PR_PULL_PATTERN = 'pull/{id}/head:external-{id}'
 
 # Git provider names
-GITHUB = 'GitHub'
+GITHUB_BRAND = 'GitHub'

readthedocs/projects/tasks.py

@@ -65,7 +65,7 @@
 from readthedocs.oauth.models import RemoteRepository
 from readthedocs.oauth.notifications import GitBuildStatusFailureNotification
 from readthedocs.oauth.services.github import GitHubService
-from readthedocs.projects.constants import GITHUB
+from readthedocs.projects.constants import GITHUB_BRAND
 from readthedocs.projects.models import APIProject, Feature
 from readthedocs.search.utils import index_new_files, remove_indexed_files
 from readthedocs.sphinx_domains.models import SphinxDomain
@@ -1892,7 +1892,7 @@ def send_build_status(build_pk, commit, status):
     build = Build.objects.get(pk=build_pk)
     provider_name = build.project.git_provider_name
 
-    if provider_name == GITHUB:
+    if provider_name == GITHUB_BRAND:
         # get the service class for the project e.g: GitHubService.
         service_class = build.project.git_service_class()
         try: