Skip to content

Commit 7d8813f

Browse files
committed
Ensure tests are actually executed
1 parent 363dccb commit 7d8813f

File tree

1 file changed

+19
-3
lines changed

1 file changed

+19
-3
lines changed

readthedocs/rtd_tests/tests/test_footer.py

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -234,10 +234,11 @@ class TestFooterPerformance(APITestCase):
234234

235235
# The expected number of queries for generating the footer
236236
# This shouldn't increase unless we modify the footer API
237-
EXPECTED_QUERIES = 2
237+
EXPECTED_QUERIES = 9
238238

239239
def setUp(self):
240240
self.pip = Project.objects.get(slug='pip')
241+
self.pip.versions.create_latest()
241242

242243
def render(self):
243244
request = self.factory.get(self.url)
@@ -248,7 +249,21 @@ def render(self):
248249
def test_version_queries(self):
249250
# The number of Versions shouldn't impact the number of queries
250251
with self.assertNumQueries(self.EXPECTED_QUERIES):
251-
self.render()
252+
response = self.render()
253+
self.assertContains(response, '0.8.1')
254+
255+
for patch in range(3):
256+
identifier = '0.99.{}'.format(patch)
257+
self.pip.versions.create(
258+
verbose_name=identifier,
259+
identifier=identifier,
260+
type=TAG,
261+
active=True,
262+
)
263+
264+
with self.assertNumQueries(self.EXPECTED_QUERIES):
265+
response = self.render()
266+
self.assertContains(response, '0.99.0')
252267

253268
def test_domain_queries(self):
254269
# Setting up a custom domain shouldn't impact the number of queries
@@ -258,4 +273,5 @@ def test_domain_queries(self):
258273
)
259274

260275
with self.assertNumQueries(self.EXPECTED_QUERIES):
261-
self.render()
276+
response = self.render()
277+
self.assertContains(response, 'docs.foobar.com')

0 commit comments

Comments
 (0)