Merge pull request #5596 from dojutsu-user/delete-super-project

Notify the user when deleting a superproject

Author: stsewd

readthedocs/projects/views/private.py

@@ -209,6 +209,11 @@ def project_delete(request, project_slug):
         slug=project_slug,
     )
 
+    context = {
+        'project': project,
+        'is_superproject': project.subprojects.all().exists()
+    }
+
     if request.method == 'POST':
         broadcast(
             type='app',
@@ -220,7 +225,7 @@ def project_delete(request, project_slug):
         project_dashboard = reverse('projects_dashboard')
         return HttpResponseRedirect(project_dashboard)
 
-    return render(request, 'projects/project_delete.html', {'project': project})
+    return render(request, 'projects/project_delete.html', context)
 
 
 class ImportWizardView(ProjectSpamMixin, PrivateViewMixin, SessionWizardView):

readthedocs/rtd_tests/tests/test_project_views.py

@@ -414,6 +414,24 @@ def test_delete_project(self):
                 args=[(project.doc_path,)],
             )
 
+    def test_delete_superproject(self):
+        super_proj = get(Project, slug='pip', users=[self.user])
+        sub_proj = get(Project, slug='test-sub-project', users=[self.user])
+
+        self.assertFalse(super_proj.subprojects.all().exists())
+        super_proj.add_subproject(sub_proj)
+
+        response = self.client.get('/dashboard/pip/delete/')
+        self.assertEqual(response.status_code, 200)
+        self.assertContains(
+            response,
+            'This project <a href="/dashboard/pip/subprojects/">has subprojects</a> under it. '
+            'Deleting this project will make them to become regular projects. '
+            'This will break the URLs of all its subprojects and they will be served normally as other projects.',
+            count=1,
+            html=True,
+        )
+
     def test_subproject_create(self):
         project = get(Project, slug='pip', users=[self.user])
         subproject = get(Project, users=[self.user])

readthedocs/templates/projects/project_delete.html

@@ -6,6 +6,18 @@
 {% block content-header %}<h1>{% blocktrans with project.name as name %}Delete {{ name }}?{% endblocktrans %}</h1>{% endblock %}
 
 {% block content %}
+
+  {% if is_superproject %}
+    {% url "projects_subprojects" project.slug as subproject_url %}
+    <p>
+      {% blocktrans trimmed %}
+        This project <a href="{{ subproject_url }}">has subprojects</a> under it.
+        Deleting this project will make them to become regular projects.
+        This will break the URLs of all its subprojects and they will be served normally as other projects.
+      {% endblocktrans %}
+    </p>
+  {% endif %}
+
   <p>{% trans "You sure?" %} O_o</p>
 
   <form method="post" action=".">{% csrf_token %}