Merge pull request #5948 from saadmk11/pr-builder-update

Small Changes to PR Builder Code

Author: ericholscher

docs/guides/feature-flags.rst

@@ -30,4 +30,4 @@ e.g. python-reno release notes manager is known to do that
 
 ``USE_TESTING_BUILD_IMAGE``: :featureflags:`USE_TESTING_BUILD_IMAGE`
 
-``ENABLE_EXTERNAL_VERSION_BUILD``: :featureflags:`ENABLE_EXTERNAL_VERSION_BUILD`
+``EXTERNAL_VERSION_BUILD``: :featureflags:`EXTERNAL_VERSION_BUILD`

readthedocs/api/v2/views/footer_views.py

@@ -9,7 +9,7 @@
 from rest_framework_jsonp.renderers import JSONPRenderer
 
 from readthedocs.api.v2.signals import footer_response
-from readthedocs.builds.constants import LATEST, TAG, INTERNAL
+from readthedocs.builds.constants import LATEST, TAG
 from readthedocs.builds.models import Version
 from readthedocs.projects.models import Project
 from readthedocs.projects.version_handling import (

readthedocs/builds/constants.py

@@ -62,33 +62,33 @@
     STABLE,
 )
 
-# GitHub Build Statuses
-GITHUB_BUILD_STATE_FAILURE = 'failure'
-GITHUB_BUILD_STATE_PENDING = 'pending'
-GITHUB_BUILD_STATE_SUCCESS = 'success'
-
 # General Build Statuses
 BUILD_STATUS_FAILURE = 'failed'
 BUILD_STATUS_PENDING = 'pending'
 BUILD_STATUS_SUCCESS = 'success'
 
+# GitHub Build Statuses
+GITHUB_BUILD_STATUS_FAILURE = 'failure'
+GITHUB_BUILD_STATUS_PENDING = 'pending'
+GITHUB_BUILD_STATUS_SUCCESS = 'success'
+
 # Used to select correct Build status and description to be sent to each service API
 SELECT_BUILD_STATUS = {
     BUILD_STATUS_FAILURE: {
-        'github': GITHUB_BUILD_STATE_FAILURE,
+        'github': GITHUB_BUILD_STATUS_FAILURE,
         'description': 'The build failed!',
     },
     BUILD_STATUS_PENDING: {
-        'github': GITHUB_BUILD_STATE_PENDING,
+        'github': GITHUB_BUILD_STATUS_PENDING,
         'description': 'The build is pending!',
     },
     BUILD_STATUS_SUCCESS: {
-        'github': GITHUB_BUILD_STATE_SUCCESS,
+        'github': GITHUB_BUILD_STATUS_SUCCESS,
         'description': 'The build succeeded!',
     },
 }
 
+RTD_BUILD_STATUS_API_NAME = 'continuous-documentation/read-the-docs'
+
 GITHUB_EXTERNAL_VERSION_NAME = 'Pull Request'
 GENERIC_EXTERNAL_VERSION_NAME = 'External Version'
-
-RTD_BUILD_STATUS_API_NAME = 'continuous-documentation/read-the-docs'

readthedocs/projects/models.py

@@ -1407,7 +1407,7 @@ def add_features(sender, **kwargs):
     SHARE_SPHINX_DOCTREE = 'share_sphinx_doctree'
     DEFAULT_TO_MKDOCS_0_17_3 = 'default_to_mkdocs_0_17_3'
     CLEAN_AFTER_BUILD = 'clean_after_build'
-    EXTERNAL_VERSION_BUILD = 'enable_external_version_build'
+    EXTERNAL_VERSION_BUILD = 'external_version_build'
     UPDATE_CONDA_STARTUP = 'update_conda_startup'
 
     FEATURES = (