Skip to content

Commit 71231cd

Browse files
committed
Fix tests
1 parent c4337a1 commit 71231cd

File tree

2 files changed

+2
-15
lines changed

2 files changed

+2
-15
lines changed

readthedocs/config/tests/test_config.py

+2-4
Original file line numberDiff line numberDiff line change
@@ -528,8 +528,8 @@ def test_it_fails_on_python_validation(self, tmpdir):
528528
build = BuildConfigV1(
529529
{},
530530
{
531-
'build': {'image': 1.0},
532-
'python': {'version': '3.3'},
531+
'build': {'image': 2.0},
532+
'python': {'version': '3.8'},
533533
},
534534
source_file=str(tmpdir.join('readthedocs.yml')),
535535
)
@@ -1000,9 +1000,7 @@ def test_python_version_default(self):
10001000
@pytest.mark.parametrize(
10011001
'image,default_version',
10021002
[
1003-
('1.0', 3.4),
10041003
('2.0', 3.5),
1005-
('3.0', 3.6),
10061004
('4.0', 3.7),
10071005
('5.0', 3.7),
10081006
('latest', 3.7),

readthedocs/rtd_tests/tests/test_config_integration.py

-11
Original file line numberDiff line numberDiff line change
@@ -116,17 +116,6 @@ def test_python_supported_versions_default_image_1_0(self, load_config):
116116
)
117117
self.assertEqual(config.python.version, 3)
118118

119-
@mock.patch('readthedocs.doc_builder.config.load_config')
120-
def test_python_supported_versions_image_1_0(self, load_config):
121-
load_config.side_effect = create_load()
122-
self.project.container_image = 'readthedocs/build:1.0'
123-
self.project.save()
124-
config = load_yaml_config(self.version)
125-
self.assertEqual(
126-
config.get_valid_python_versions(),
127-
[2, 2.7, 3, 3.4],
128-
)
129-
130119
@mock.patch('readthedocs.doc_builder.config.load_config')
131120
def test_python_supported_versions_image_2_0(self, load_config):
132121
load_config.side_effect = create_load()

0 commit comments

Comments
 (0)