Merge pull request #5262 from rtfd/fix-search-delete

ericholscher · web-flow · commit 6fa0dd33c31a · 2019-02-11T15:54:02.000-03:00
Don’t delay search delete on project delete
diff --git a/readthedocs/search/signals.py b/readthedocs/search/signals.py
@@ -73,6 +73,6 @@ def remove_project_delete(instance, *args, **kwargs):
         'objects_id': [instance.id],
     }
 
-    # Do not index if autosync is disabled globally
+    # Don't `delay` this because the objects will be deleted already
     if DEDConfig.autosync_enabled():
-        delete_objects_in_es.delay(**kwargs)
+        delete_objects_in_es(**kwargs)

Original file line number	Diff line number	Diff line change
`@@ -73,6 +73,6 @@ def remove_project_delete(instance, args, *kwargs):`
`73`	`73`	`'objects_id': [instance.id],`
`74`	`74`	`}`
`75`	`75`
`76`		`- # Do not index if autosync is disabled globally`
	`76`	+ # Don't `delay` this because the objects will be deleted already
`77`	`77`	`if DEDConfig.autosync_enabled():`
`78`		`- delete_objects_in_es.delay(**kwargs)`
	`78`	`+ delete_objects_in_es(**kwargs)`