Allow users to change version slug

Author: stsewd

readthedocs/builds/forms.py

@@ -30,6 +30,7 @@ class Meta:
         states_fields = ["active", "hidden"]
         privacy_fields = ["privacy_level"]
         fields = (
+            "slug",
             *states_fields,
             *privacy_fields,
         )
@@ -88,8 +89,22 @@ def _is_default_version(self):
         project = self.instance.project
         return project.default_version == self.instance.slug
 
+    def clean_slug(self):
+        slug = self.cleaned_data["slug"]
+        if "slug" in self.changed_data and self.instance.machine:
+            raise forms.ValidationError(
+                _("The slug cannot be changed."),
+            )
+        # TODO: check for unique slug instead of having django 500.
+        return slug
+
     def save(self, commit=True):
         obj = super().save(commit=commit)
+
+        if "slug" in self.changed_data and self._was_active and self.instance.active:
+            obj.recreate()
+            return obj
+
         obj.post_save(was_active=self._was_active)
         return obj
 

readthedocs/builds/models.py

@@ -440,6 +440,11 @@ def post_save(self, was_active=False):
             trigger_build(project=self.project, version=self)
         # Purge the cache from the CDN.
         version_changed.send(sender=self.__class__, version=self)
+    
+    def recreate(self):
+        self.clean_resources()
+        trigger_build(project=self.project, version=self)
+        version_changed.send(sender=self.__class__, version=self)
 
     @property
     def identifier_friendly(self):