Skip to content

Commit 6c6d1b9

Browse files
committed
Remove .save overrides
1 parent dbabcdc commit 6c6d1b9

File tree

2 files changed

+0
-19
lines changed

2 files changed

+0
-19
lines changed

readthedocs/builds/models.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -782,10 +782,6 @@ def save(self, *args, **kwargs): # noqa
782782
self.version_slug = self.version.slug
783783
self.version_type = self.version.type
784784

785-
# TODO: delete copying config after deploy
786-
# Copy `_config` into the new `_config_json` JSONField
787-
self._config_json = self._config
788-
789785
super().save(*args, **kwargs)
790786
self._config_changed = False
791787

readthedocs/integrations/models.py

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -175,15 +175,6 @@ class Meta:
175175
def __str__(self):
176176
return _('Exchange {0}').format(self.pk)
177177

178-
# TODO: delete .save method after deploy
179-
# Copy headers into new JSONField
180-
def save(self, *args, **kwargs):
181-
# NOTE: cast headers into a regular dict because Django does not know
182-
# how to serialize ``requests.structures.CaseInsensitiveDict``
183-
self.request_headers_json = dict(self.request_headers)
184-
self.response_headers_json = dict(self.response_headers)
185-
super().save(*args, **kwargs)
186-
187178
@property
188179
def failed(self):
189180
# Assume anything that isn't 2xx level status code is an error
@@ -328,12 +319,6 @@ def remove_secret(self):
328319
self.secret = None
329320
self.save(update_fields=['secret'])
330321

331-
# TODO: delete .save method after deploy
332-
# Copy `provider_data` into new JSONField
333-
def save(self, *args, **kwargs):
334-
self.provider_data_json = self.provider_data
335-
super().save(*args, **kwargs)
336-
337322
def __str__(self):
338323
return (
339324
_('{0} for {1}')

0 commit comments

Comments
 (0)