Allow extend Translation and Subproject form logic from corporate (#3937)

* Allow extend Translation and Subproject form logic from corporate

* Remove old style setting override

Author: humitos

readthedocs/projects/forms.py

@@ -4,9 +4,9 @@
 from __future__ import (
     absolute_import, division, print_function, unicode_literals)
 
-from builtins import object
 from random import choice
 
+from builtins import object
 from django import forms
 from django.conf import settings
 from django.contrib.auth.models import User
@@ -19,6 +19,7 @@
 
 from readthedocs.builds.constants import TAG
 from readthedocs.core.utils import slugify, trigger_build
+from readthedocs.core.utils.extend import SettingsOverrideObject
 from readthedocs.integrations.models import Integration
 from readthedocs.oauth.models import RemoteRepository
 from readthedocs.projects import constants
@@ -230,7 +231,7 @@ class Meta(object):
         )
 
 
-class ProjectRelationshipForm(forms.ModelForm):
+class ProjectRelationshipBaseForm(forms.ModelForm):
 
     """Form to add/update project relationships."""
 
@@ -243,7 +244,7 @@ class Meta(object):
     def __init__(self, *args, **kwargs):
         self.project = kwargs.pop('project')
         self.user = kwargs.pop('user')
-        super(ProjectRelationshipForm, self).__init__(*args, **kwargs)
+        super(ProjectRelationshipBaseForm, self).__init__(*args, **kwargs)
         # Don't display the update form with an editable child, as it will be
         # filtered out from the queryset anyways.
         if hasattr(self, 'instance') and self.instance.pk is not None:
@@ -281,6 +282,10 @@ def get_subproject_queryset(self):
         return queryset
 
 
+class ProjectRelationshipForm(SettingsOverrideObject):
+    _default_class = ProjectRelationshipBaseForm
+
+
 class DualCheckboxWidget(forms.CheckboxInput):
 
     """Checkbox with link to the version's built documentation."""
@@ -481,7 +486,7 @@ def save(self):
         return self.project
 
 
-class TranslationForm(forms.Form):
+class TranslationBaseForm(forms.Form):
 
     """Project translation form."""
 
@@ -490,7 +495,7 @@ class TranslationForm(forms.Form):
     def __init__(self, *args, **kwargs):
         self.parent = kwargs.pop('parent', None)
         self.user = kwargs.pop('user')
-        super(TranslationForm, self).__init__(*args, **kwargs)
+        super(TranslationBaseForm, self).__init__(*args, **kwargs)
         self.fields['project'].choices = self.get_choices()
 
     def get_choices(self):
@@ -563,6 +568,10 @@ def save(self):
         return project
 
 
+class TranslationForm(SettingsOverrideObject):
+    _default_class = TranslationBaseForm
+
+
 class RedirectForm(forms.ModelForm):
 
     """Form for project redirects."""