Merge pull request #3725 from bansalnitish/fixUrl

Fixes #2953 - Url resolved with special characters

Author: humitos

readthedocs/profiles/urls/public.py

@@ -7,7 +7,7 @@
 
 
 urlpatterns = [
-    url(r'^(?P<username>[\[email protected]]+)/$',
+    url(r'^(?P<username>[+\[email protected]]+)/$',
         views.profile_detail,
         {'template_name': 'profiles/public/profile_detail.html'},
         name='profiles_profile_detail'),

readthedocs/rtd_tests/tests/test_urls.py

@@ -51,3 +51,25 @@ def test_version_url_with_caps(self):
             kwargs={'type_': 'pdf', 'version_slug': u'1.4.X', 'project_slug': u'django'}
         )
         self.assertTrue(url)
+
+
+class TestProfileDetailURLs(TestCase):
+
+    def test_profile_detail_url(self):
+        url = reverse(
+            'profiles_profile_detail',
+            kwargs={'username': 'foo+bar'}
+            )
+        self.assertEqual(url, '/profiles/foo+bar/')
+
+        url = reverse(
+            'profiles_profile_detail',
+            kwargs={'username': '[email protected]'}
+            )
+        self.assertEqual(url, '/profiles/[email protected]/')
+
+        url = reverse(
+            'profiles_profile_detail',
+            kwargs={'username': 'abc-def+ghi'}
+            )
+        self.assertEqual(url, '/profiles/abc-def+ghi/')