Skip to content

Commit 67e1ae0

Browse files
ericholscheragjohnson
authored andcommitted
Fix issue with pip 20.0 breaking on install (#6598)
* Upgrade pip to above its broken version * Call virtualenv without no-download * Add comment * link to issue: #6585
1 parent 97bbf84 commit 67e1ae0

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

readthedocs/doc_builder/python_environments.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,10 @@ def setup_base(self):
298298
self.config.python_interpreter,
299299
'-mvirtualenv',
300300
site_packages,
301-
'--no-download',
301+
# This is removed because of the pip breakage,
302+
# it was sometimes installing pip 20.0 which broke everything
303+
# https://github.com/readthedocs/readthedocs.org/issues/6585
304+
# '--no-download',
302305
env_path,
303306
# Don't use virtualenv bin that doesn't exist yet
304307
bin_path=None,

0 commit comments

Comments
 (0)