Skip to content

Commit 67d5595

Browse files
committed
Fix tests
1 parent c27686e commit 67d5595

File tree

1 file changed

+13
-21
lines changed

1 file changed

+13
-21
lines changed

readthedocs/rtd_tests/tests/test_config_wrapper.py

Lines changed: 13 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -54,45 +54,37 @@ def test_python_supported_versions_default_image_1_0(self, load_config):
5454
self.assertEqual(load_config.call_count, 1)
5555
load_config.assert_has_calls([
5656
mock.call(path=mock.ANY, env_config={
57-
'python': {'supported_versions': [2, 2.7, 3, 3.4]},
57+
'build': {'image': 'readthedocs/build:1.0'},
5858
'type': 'sphinx',
5959
'output_base': '',
6060
'name': mock.ANY
6161
}),
6262
])
6363
self.assertEqual(config.python_version, 2)
6464

65+
def test_python_supported_versions_image_1_0(self, load_config):
66+
load_config.side_effect = create_load()
67+
self.project.container_image = 'readthedocs/build:1.0'
68+
self.project.save()
69+
config = load_yaml_config(self.version)
70+
self.assertEqual(config._yaml_config.get_valid_python_versions(),
71+
[2, 2.7, 3, 3.4])
72+
6573
def test_python_supported_versions_image_2_0(self, load_config):
6674
load_config.side_effect = create_load()
6775
self.project.container_image = 'readthedocs/build:2.0'
6876
self.project.save()
6977
config = load_yaml_config(self.version)
70-
self.assertEqual(load_config.call_count, 1)
71-
load_config.assert_has_calls([
72-
mock.call(path=mock.ANY, env_config={
73-
'python': {'supported_versions': [2, 2.7, 3, 3.5]},
74-
'type': 'sphinx',
75-
'output_base': '',
76-
'name': mock.ANY
77-
}),
78-
])
79-
self.assertEqual(config.python_version, 2)
78+
self.assertEqual(config._yaml_config.get_valid_python_versions(),
79+
[2, 2.7, 3, 3.5])
8080

8181
def test_python_supported_versions_image_latest(self, load_config):
8282
load_config.side_effect = create_load()
8383
self.project.container_image = 'readthedocs/build:latest'
8484
self.project.save()
8585
config = load_yaml_config(self.version)
86-
self.assertEqual(load_config.call_count, 1)
87-
load_config.assert_has_calls([
88-
mock.call(path=mock.ANY, env_config={
89-
'python': {'supported_versions': [2, 2.7, 3, 3.3, 3.4, 3.5, 3.6]},
90-
'type': 'sphinx',
91-
'output_base': '',
92-
'name': mock.ANY
93-
}),
94-
])
95-
self.assertEqual(config.python_version, 2)
86+
self.assertEqual(config._yaml_config.get_valid_python_versions(),
87+
[2, 2.7, 3, 3.3, 3.4, 3.5, 3.6])
9688

9789
def test_python_default_version(self, load_config):
9890
load_config.side_effect = create_load()

0 commit comments

Comments
 (0)