Merge pull request #4967 from dojutsu-user/validate-tags-length-100-characters

Add validation for tags of length greater than 100 characters

Author: ericholscher

readthedocs/projects/forms.py

@@ -182,6 +182,15 @@ class Meta(object):
         widget=forms.Textarea,
     )
 
+    def clean_tags(self):
+        tags = self.cleaned_data.get('tags', [])
+        for tag in tags:
+            if len(tag) > 100:
+                raise forms.ValidationError(
+                    _('Length of each tag must be less than or equal to 100 characters.')
+                )
+        return tags
+
 
 class ProjectAdvancedForm(ProjectTriggerBuildMixin, ProjectForm):
 

readthedocs/rtd_tests/tests/test_project_forms.py

@@ -163,6 +163,26 @@ def test_changing_vcs_should_not_change_latest_is_not_none(self):
         latest.refresh_from_db()
         self.assertEqual(latest.identifier, 'custom')
 
+    def test_length_of_tags(self):
+        data = {
+            'documentation_type': 'sphinx',
+            'language': 'en'
+        }
+        data['tags'] = '{},{}'.format('a'*50, 'b'*99)
+        form = ProjectExtraForm(data)
+        self.assertTrue(form.is_valid())
+
+        data['tags'] = '{},{}'.format('a'*90, 'b'*100)
+        form = ProjectExtraForm(data)
+        self.assertTrue(form.is_valid())
+        
+        data['tags'] = '{},{}'.format('a'*99, 'b'*101)
+        form = ProjectExtraForm(data)
+        self.assertFalse(form.is_valid())
+        self.assertTrue(form.has_error('tags'))
+        error_msg = 'Length of each tag must be less than or equal to 100 characters.'
+        self.assertDictEqual(form.errors, {'tags': [error_msg]})
+
 
 class TestProjectAdvancedForm(TestCase):