Skip to content

Commit 6402c26

Browse files
moved 'expandable_fields' to meta class
1 parent 9125deb commit 6402c26

File tree

1 file changed

+14
-24
lines changed

1 file changed

+14
-24
lines changed

readthedocs/api/v3/serializers.py

Lines changed: 14 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -115,14 +115,9 @@ class BuildSerializer(FlexFieldsModelSerializer):
115115
state = BuildStateSerializer(source='*')
116116
_links = BuildLinksSerializer(source='*')
117117

118-
expandable_fields = dict(
119-
config=(
120-
BuildConfigSerializer,
121-
dict(
122-
source='config',
123-
),
124-
),
125-
)
118+
expandable_fields = {
119+
'config': (BuildConfigSerializer, {'source': 'config'})
120+
}
126121

127122
class Meta:
128123
model = Build
@@ -215,14 +210,9 @@ class VersionSerializer(FlexFieldsModelSerializer):
215210
urls = VersionURLsSerializer(source='*')
216211
_links = VersionLinksSerializer(source='*')
217212

218-
expandable_fields = dict(
219-
last_build=(
220-
BuildSerializer,
221-
dict(
222-
source='last_build',
223-
),
224-
),
225-
)
213+
expandable_fields = {
214+
'last_build': (BuildSerializer, {'source': 'last_build'})
215+
}
226216

227217
class Meta:
228218
model = Version
@@ -448,17 +438,17 @@ class ProjectSerializer(FlexFieldsModelSerializer):
448438
created = serializers.DateTimeField(source='pub_date')
449439
modified = serializers.DateTimeField(source='modified_date')
450440

451-
expandable_fields = dict(
452-
active_versions=(
441+
expandable_fields = {
442+
'active_versions': (
453443
VersionSerializer,
454-
dict(
444+
{
455445
# NOTE: this has to be a Model method, can't be a
456446
# ``SerializerMethodField`` as far as I know
457-
source='active_versions',
458-
many=True,
459-
),
460-
),
461-
)
447+
'source': 'active_versions',
448+
'many': True,
449+
}
450+
)
451+
}
462452

463453
class Meta:
464454
model = Project

0 commit comments

Comments
 (0)