Skip to content

Commit 5f6917c

Browse files
committed
Cleanup test code and comment it
1 parent b4a9fd7 commit 5f6917c

File tree

1 file changed

+7
-15
lines changed

1 file changed

+7
-15
lines changed

readthedocs/rtd_tests/tests/test_sync_versions.py

+7-15
Original file line numberDiff line numberDiff line change
@@ -478,6 +478,7 @@ def test_user_defined_stable_version_with_tags(self):
478478
active=True,
479479
)
480480

481+
# A pre-existing active stable branch that was machine created
481482
Version.objects.create(
482483
project=self.pip,
483484
identifier='foo',
@@ -493,14 +494,11 @@ def test_user_defined_stable_version_with_tags(self):
493494
'identifier': 'origin/master',
494495
'verbose_name': 'master',
495496
},
497+
# A new user-defined stable branch
496498
{
497499
'identifier': 'origin/stable',
498500
'verbose_name': 'stable',
499501
},
500-
{
501-
'identifier': 'origin/to_add',
502-
'verbose_name': 'to_add',
503-
},
504502
],
505503
'tags': [
506504
{
@@ -520,27 +518,21 @@ def test_user_defined_stable_version_with_tags(self):
520518
content_type='application/json',
521519
)
522520

521+
# Didn't update to newest tag
523522
version_9 = Version.objects.get(slug='0.9')
524523
self.assertFalse(version_9.active)
525524

525+
# Did update to user-defined stable version
526526
version_stable = Version.objects.get(slug='stable')
527527
self.assertFalse(version_stable.machine)
528528
self.assertTrue(version_stable.active)
529+
self.assertEqual('origin/stable', self.pip.get_stable_version().identifier)
529530

530-
# Version 0.9 doesn't become stable, since we already had a user-defined stable
531-
self.assertEqual(
532-
'origin/stable',
533-
self.pip.get_stable_version().identifier,
534-
)
535-
531+
# Check that posting again doesn't change anything from current state.
536532
self.client.post(
537533
'/api/v2/project/{}/sync_versions/'.format(self.pip.pk),
538534
data=json.dumps(version_post_data),
539535
content_type='application/json',
540536
)
541537

542-
# Version 0.9 doesn't become stable, since we already had a user-defined stable
543-
self.assertEqual(
544-
'origin/stable',
545-
self.pip.get_stable_version().identifier,
546-
)
538+
self.assertEqual('origin/stable', self.pip.get_stable_version().identifier)

0 commit comments

Comments
 (0)