Bring back project privacy level

But... only for .com and is used to show the dashboard and build output
of public versions

Closes #2663

Author: stsewd

docs/commercial/index.rst

@@ -35,4 +35,5 @@ Advertising-free
    organizations
    single-sign-on
    sharing
+   privacy-level
    analytics

docs/commercial/privacy-level.rst

@@ -0,0 +1,20 @@
+Project Privacy Level
+---------------------
+
+.. note::
+
+   This feature only exists on `Read the Docs for Business <https://readthedocs.com/>`__.
+
+By default, only users that belong to your organization can see the dashboard of your project and its builds.
+If you want users outside your organization and anonymous users to be able to see the dashboard of your project,
+and the build output of *public versions* you can set the privacy level of your project to ``Public``.
+
+- Go the :guilabel:`Admin` tab of your project.
+- Click on :guilabel:`Advanced Settings`.
+- Change to :guilabel:`Privacy level` to `Public`.
+
+
+.. note::
+
+   To control access to the documentation itself,
+   see :ref:`versions:privacy levels`.

docs/versions.rst

@@ -111,6 +111,9 @@ Private versions are available only to people who have permissions to see them.
 They will not display on any list view, and will 404 when you link them to others.
 If you want to share your docs temporarily, see :doc:`/commercial/sharing`.
 
+In addition, if you want other users to view the build page of your public versions,
+you'll neeed to the set the :doc:`privacy level of your project </commercial/privacy-level>` to public.
+
 Tags and branches
 -----------------
 

readthedocs/projects/forms.py

@@ -4,7 +4,7 @@
 from urllib.parse import urlparse
 
 from crispy_forms.helper import FormHelper
-from crispy_forms.layout import Fieldset, Layout, HTML, Submit
+from crispy_forms.layout import HTML, Fieldset, Layout, Submit
 from django import forms
 from django.conf import settings
 from django.contrib.auth.models import User
@@ -14,6 +14,7 @@
 from textclassifier.validators import ClassifierValidator
 
 from readthedocs.builds.constants import INTERNAL
+from readthedocs.core.mixins import HideProtectedLevelMixin
 from readthedocs.core.utils import slugify, trigger_build
 from readthedocs.core.utils.extend import SettingsOverrideObject
 from readthedocs.integrations.models import Integration
@@ -190,7 +191,7 @@ def clean_tags(self):
         return tags
 
 
-class ProjectAdvancedForm(ProjectTriggerBuildMixin, ProjectForm):
+class ProjectAdvancedForm(HideProtectedLevelMixin, ProjectTriggerBuildMixin, ProjectForm):
 
     """Advanced project option form."""
 
@@ -203,7 +204,8 @@ class Meta:
             'analytics_disabled',
             'show_version_warning',
             'single_version',
-            'external_builds_enabled'
+            'external_builds_enabled',
+            'privacy_level',
         )
         # These that can be set per-version using a config file.
         per_version_settings = (
@@ -232,17 +234,24 @@ def __init__(self, *args, **kwargs):
         help_text = render_to_string(
             'projects/project_advanced_settings_helptext.html'
         )
-        self.helper.layout = Layout(
+
+        per_project_settings = list(self.Meta.per_project_settings)
+        if not settings.ALLOW_PRIVATE_REPOS:
+            self.fields.pop('privacy_level')
+            per_project_settings.remove('privacy_level')
+
+        field_sets = [
             Fieldset(
                 _("Global settings"),
-                *self.Meta.per_project_settings,
+                *per_project_settings,
             ),
             Fieldset(
                 _("Default settings"),
                 HTML(help_text),
                 *self.Meta.per_version_settings,
             ),
-        )
+        ]
+        self.helper.layout = Layout(*field_sets)
         self.helper.add_input(Submit('save', _('Save')))
 
         default_choice = (None, '-' * 9)

readthedocs/projects/migrations/0064_change_privacy_level_description.py

@@ -0,0 +1,18 @@
+# Generated by Django 2.2.16 on 2020-10-01 18:00
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('projects', '0063_extend_domain_from_timestamp_model'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='project',
+            name='privacy_level',
+            field=models.CharField(choices=[('public', 'Public'), ('protected', 'Protected'), ('private', 'Private')], default='public', help_text='Should the project dashboard be public?', max_length=20, verbose_name='Privacy Level'),
+        ),
+    ]

readthedocs/projects/models.py

@@ -365,7 +365,7 @@ class Project(models.Model):
         choices=constants.PRIVACY_CHOICES,
         default=settings.DEFAULT_PRIVACY_LEVEL,
         help_text=_(
-            'Level of privacy that you want on the repository.',
+            'Should the project dashboard be public?',
         ),
     )
 

readthedocs/rtd_tests/tests/test_project_forms.py

@@ -15,6 +15,7 @@
     PUBLIC,
     REPO_TYPE_GIT,
     REPO_TYPE_HG,
+    SPHINX,
 )
 from readthedocs.projects.exceptions import ProjectSpamError
 from readthedocs.projects.forms import (
@@ -274,6 +275,35 @@ def test_default_version_field_if_no_active_version(self):
         self.assertTrue(form.fields['default_version'].widget.attrs['readonly'])
         self.assertEqual(form.fields['default_version'].initial, 'latest')
 
+    @override_settings(ALLOW_PRIVATE_REPOS=False)
+    def test_cant_update_privacy_level(self):
+        form = ProjectAdvancedForm(
+            {
+                'default_version': LATEST,
+                'documentation_type': SPHINX,
+                'python_interpreter': 'python3',
+                'privacy_level': PRIVATE,
+            },
+            instance=self.project,
+        )
+        # The form is valid, but the field is ignored
+        self.assertTrue(form.is_valid())
+        self.assertEqual(self.project.privacy_level, PUBLIC)
+
+    @override_settings(ALLOW_PRIVATE_REPOS=True)
+    def test_can_update_privacy_level(self):
+        form = ProjectAdvancedForm(
+            {
+                'default_version': LATEST,
+                'documentation_type': SPHINX,
+                'python_interpreter': 'python3',
+                'privacy_level': PRIVATE,
+            },
+            instance=self.project,
+        )
+        self.assertTrue(form.is_valid())
+        self.assertEqual(self.project.privacy_level, PRIVATE)
+
 
 class TestProjectAdvancedFormDefaultBranch(TestCase):