Updates from review

stsewd · stsewd · commit 5f5793eda3ee · 2022-06-14T17:00:47.000-05:00
diff --git a/readthedocs/projects/models.py b/readthedocs/projects/models.py
@@ -1443,6 +1443,8 @@ def get_processed_json(self):
             log.warning(
                 "Invalid documentation type",
                 documentation_type=self.version.documentation_type,
+                version_slug=self.version.slug,
+                project_slug=self.project.slug,
             )
             return {}
         parser = parser_class(self.version)
diff --git a/readthedocs/search/parsers.py b/readthedocs/search/parsers.py
@@ -312,7 +312,7 @@ def parse(self, page):
             content = self._get_page_content(page)
             if content:
                 return self._process_content(page, content)
-        except Exception as e:
+        except Exception:
             log.info("Failed to index page.", path=page, exc_info=True)
         return {
             "path": page,
diff --git a/readthedocs/search/tests/data/generic/in/basic.html b/readthedocs/search/tests/data/generic/in/basic.html
@@ -2,9 +2,9 @@
 <html>
   <head>
     <meta charset="utf-8">
-    <title>My first web page</title>
+    <title>Title of the page</title>
   </head>
   <body>
-    My first web page!
+    Content of the body.
   </body>
 </html>
diff --git a/readthedocs/search/tests/data/generic/out/basic.json b/readthedocs/search/tests/data/generic/out/basic.json
@@ -1,12 +1,12 @@
 [
   {
-    "title": "My first web page",
+    "title": "Title of the page",
     "path": "basic.html",
     "sections": [
       {
         "id": "",
-        "title": "My first web page",
-        "content": "My first web page!"
+        "title": "Title of the page",
+        "content": "Content of the body."
       }
     ],
     "domain_data": {}

Original file line number	Diff line number	Diff line change
`@@ -1443,6 +1443,8 @@ def get_processed_json(self):`
`1443`	`1443`	`log.warning(`
`1444`	`1444`	`"Invalid documentation type",`
`1445`	`1445`	`documentation_type=self.version.documentation_type,`
	`1446`	`+ version_slug=self.version.slug,`
	`1447`	`+ project_slug=self.project.slug,`
`1446`	`1448`	`)`
`1447`	`1449`	`return {}`
`1448`	`1450`	`parser = parser_class(self.version)`
Original file line number	Diff line number	Diff line change
`@@ -1,12 +1,12 @@`
`1`	`1`	`[`
`2`	`2`	`{`
`3`		`- "title": "My first web page",`
	`3`	`+ "title": "Title of the page",`
`4`	`4`	`"path": "basic.html",`
`5`	`5`	`"sections": [`
`6`	`6`	`{`
`7`	`7`	`"id": "",`
`8`		`- "title": "My first web page",`
`9`		`- "content": "My first web page!"`
	`8`	`+ "title": "Title of the page",`
	`9`	`+ "content": "Content of the body."`
`10`	`10`	`}`
`11`	`11`	`],`
`12`	`12`	`"domain_data": {}`