Skip to content

Commit 5f15af7

Browse files
committed
Revert "Remove showing errors from build.error"
This reverts commit d4951a8. We decided to keep this code around for now. See #10980 (comment)
1 parent e711d8f commit 5f15af7

File tree

1 file changed

+25
-0
lines changed

1 file changed

+25
-0
lines changed

readthedocs/templates/builds/build_detail.html

+25
Original file line numberDiff line numberDiff line change
@@ -225,6 +225,31 @@ <h3>{{ notification.get_message.type|title }}</h3>
225225
{% endif %}
226226
{% endfor %}
227227

228+
<div class="build-error"
229+
data-bind="visible: error"
230+
style="display: none;">
231+
<h3>{% trans "Error" %}</h3>
232+
<p class="build-error"
233+
data-bind="text: error">
234+
{#
235+
I'd like to use ``build.error|urlize`` here, so we can have nice links.
236+
However, this is not possible because we are using `data-bind="text: error"`
237+
which means that Knockout.js will use the `.error` attribute to fill
238+
the content of this tag dynamically.
239+
#}
240+
{{ build.error|urlize }}
241+
</p>
242+
<p>
243+
{% block github_issue_link %}
244+
{% if issue_url %}
245+
{% blocktrans trimmed with url=issue_url %}
246+
<a href="{{ url }}">Report any build issues here</a>.
247+
{% endblocktrans %}
248+
{% endif %}
249+
{% endblock %}
250+
</p>
251+
</div>
252+
228253
<div id="build-commands"
229254
class="build-command-list"
230255
data-bind="visible: commands, foreach: display_commands"

0 commit comments

Comments
 (0)