restapi: decouple ProjectViewSet from the pk

We may want to hook the very same viewset under a different
router in order to lookup by slug and not pk. If we use
lookup_field instead of hardcoding it in the views, it becomes
easier. While at it reuse get_queryset() method for filtering
the queryset.

Author: xrmx

readthedocs/restapi/views/model_views.py

@@ -92,11 +92,16 @@ class ProjectViewSet(UserSelectViewSet):
     model = Project
     pagination_class = api_utils.ProjectPagination
 
+    def get_project_for_user_or_404(self, lookup_value):
+        lookup_query = {self.lookup_field: lookup_value}
+        qs = self.get_queryset()
+        return get_object_or_404(qs, **lookup_query)
+
     @decorators.detail_route()
     def valid_versions(self, request, **kwargs):
         """Maintain state of versions that are wanted."""
-        project = get_object_or_404(
-            Project.objects.api(request.user), pk=kwargs['pk'])
+        project = self.get_project_for_user_or_404(
+            kwargs[self.lookup_field])
         if (not project.num_major or not project.num_minor or
                 not project.num_point):
             return Response(
@@ -124,8 +129,8 @@ def translations(self, *_, **__):
 
     @detail_route()
     def subprojects(self, request, **kwargs):
-        project = get_object_or_404(
-            Project.objects.api(request.user), pk=kwargs['pk'])
+        project = self.get_project_for_user_or_404(
+            kwargs[self.lookup_field])
         rels = project.subprojects.all()
         children = [rel.child for rel in rels]
         return Response({
@@ -134,26 +139,26 @@ def subprojects(self, request, **kwargs):
 
     @detail_route()
     def active_versions(self, request, **kwargs):
-        project = get_object_or_404(
-            Project.objects.api(request.user), pk=kwargs['pk'])
+        project = self.get_project_for_user_or_404(
+            kwargs[self.lookup_field])
         versions = project.versions.filter(active=True)
         return Response({
             'versions': VersionSerializer(versions, many=True).data,
         })
 
     @decorators.detail_route(permission_classes=[permissions.IsAdminUser])
     def token(self, request, **kwargs):
-        project = get_object_or_404(
-            Project.objects.api(request.user), pk=kwargs['pk'])
+        project = self.get_project_for_user_or_404(
+            kwargs[self.lookup_field])
         token = GitHubService.get_token_for_project(project, force_local=True)
         return Response({
             'token': token,
         })
 
     @decorators.detail_route()
     def canonical_url(self, request, **kwargs):
-        project = get_object_or_404(
-            Project.objects.api(request.user), pk=kwargs['pk'])
+        project = self.get_project_for_user_or_404(
+            kwargs[self.lookup_field])
         return Response({
             'url': project.get_docs_url(),
         })
@@ -168,8 +173,8 @@ def sync_versions(self, request, **kwargs):  # noqa: D205
 
         :returns: the identifiers for the versions that have been deleted.
         """
-        project = get_object_or_404(
-            Project.objects.api(request.user), pk=kwargs['pk'])
+        project = self.get_project_for_user_or_404(
+            kwargs[self.lookup_field])
 
         # If the currently highest non-prerelease version is active, then make
         # the new latest version active as well.