Build Managers added

Author: saadmk11

readthedocs/builds/managers.py

@@ -21,7 +21,7 @@
     TAG,
     PULL_REQUEST,
 )
-from .querysets import VersionQuerySet
+from .querysets import VersionQuerySet, BuildQuerySet
 
 log = logging.getLogger(__name__)
 
@@ -124,3 +124,63 @@ class InternalVersionManager(SettingsOverrideObject):
 class ExternalVersionManager(SettingsOverrideObject):
     _default_class = ExternalVersionManagerBase
     _override_setting = 'EXTERNAL_VERSION_MANAGER'
+
+
+class BuildManagerBase(models.Manager):
+
+    """
+    Build manager for manager only queries.
+
+    For creating different Managers.
+    """
+
+    @classmethod
+    def from_queryset(cls, queryset_class, class_name=None):
+        # This is overridden because :py:meth:`models.Manager.from_queryset`
+        # uses `inspect` to retrieve the class methods, and the proxy class has
+        # no direct members.
+        queryset_class = get_override_class(
+            BuildQuerySet,
+            BuildQuerySet._default_class,  # pylint: disable=protected-access
+        )
+        return super().from_queryset(queryset_class, class_name)
+
+
+class InternalBuildManagerBase(BuildManagerBase):
+
+    """
+    Build manager that only includes internal version builds.
+
+    It will exclude PULL_REQUEST type Version builds from the queries
+    and only include BRANCH, TAG, UNKONWN type Version builds.
+    """
+
+    def get_queryset(self):
+        return super().get_queryset().exclude(version__type=PULL_REQUEST)
+
+
+class ExternalBuildManagerBase(BuildManagerBase):
+
+    """
+    Build manager that only includes external version builds.
+
+    It will only include PULL_REQUEST type Versions builds in the queries.
+    """
+
+    def get_queryset(self):
+        return super().get_queryset().filter(version__type=PULL_REQUEST)
+
+
+class BuildManager(SettingsOverrideObject):
+    _default_class = BuildManagerBase
+    _override_setting = 'BUILD_MANAGER'
+
+
+class InternalBuildManager(SettingsOverrideObject):
+    _default_class = InternalBuildManagerBase
+    _override_setting = 'INTERNAL_BUILD_MANAGER'
+
+
+class ExternalBuildManager(SettingsOverrideObject):
+    _default_class = ExternalBuildManagerBase
+    _override_setting = 'EXTERNAL_BUILD_MANAGER'

readthedocs/builds/models.py

@@ -46,18 +46,25 @@
     TAG,
     VERSION_TYPES,
 )
-from .managers import (
+from readthedocs.builds.managers import (
     VersionManager,
     InternalVersionManager,
-    ExternalVersionManager
+    ExternalVersionManager,
+    BuildManager,
+    InternalBuildManager,
+    ExternalBuildManager,
 )
-from .querysets import BuildQuerySet, RelatedBuildQuerySet, VersionQuerySet
-from .utils import (
+from readthedocs.builds.querysets import (
+    BuildQuerySet,
+    RelatedBuildQuerySet,
+    VersionQuerySet,
+)
+from readthedocs.builds.utils import (
     get_bitbucket_username_repo,
     get_github_username_repo,
     get_gitlab_username_repo,
 )
-from .version_slug import VersionSlugField
+from readthedocs.builds.version_slug import VersionSlugField
 
 
 log = logging.getLogger(__name__)
@@ -627,9 +634,12 @@ class Build(models.Model):
         help_text='Build steps stored outside the database.',
     )
 
-    # Manager
-
-    objects = BuildQuerySet.as_manager()
+    # Managers
+    objects = BuildManager.from_queryset(BuildQuerySet)()
+    # Only include BRANCH, TAG, UNKONWN type Version builds.
+    internal = InternalBuildManager.from_queryset(BuildQuerySet)()
+    # Only include PULL_REQUEST type Version builds.
+    external = ExternalBuildManager.from_queryset(BuildQuerySet)()
 
     CONFIG_KEY = '__config'
 

readthedocs/builds/querysets.py

@@ -116,7 +116,6 @@ def api(self, user=None, detail=True):
 
 class BuildQuerySet(SettingsOverrideObject):
     _default_class = BuildQuerySetBase
-    _override_setting = 'BUILD_MANAGER'
 
 
 class RelatedBuildQuerySetBase(models.QuerySet):