Skip to content

Commit 5151e1c

Browse files
stsewdericholscher
stsewd
authored and
ericholscher
committed
Fix tests
1 parent 3c3240c commit 5151e1c

File tree

3 files changed

+55
-151
lines changed

3 files changed

+55
-151
lines changed

‎readthedocs/rtd_tests/tests/test_core_tags.py

Lines changed: 11 additions & 114 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,15 @@ def setUp(self):
2121
)
2222

2323
self.pip_latest_url = url_base.format(version='/en/latest/')
24+
self.pip_latest_url_index = url_base.format(version='/en/latest/index.html')
2425
self.pip_latest_fr_url = url_base.format(version='/fr/latest/')
2526
self.pip_abc_url = url_base.format(version='/en/abc/')
27+
self.pip_abc_url_index = url_base.format(version='/en/abc/index.html')
2628
self.pip_abc_fr_url = url_base.format(version='/fr/abc/')
27-
self.pip_abc_xyz_page_url = url_base.format(version='/en/abc/xyz.html')
28-
self.pip_abc_xyz_fr_page_url = url_base.format(version='/fr/abc/xyz.html')
29-
self.pip_abc_xyz_dir_url = url_base.format(version='/en/abc/xyz/')
30-
self.pip_abc_xyz_fr_dir_url = url_base.format(version='/fr/abc/xyz/')
31-
self.pip_abc_xyz_document = url_base.format(version='/en/abc/index.html#document-xyz')
32-
self.pip_abc_xyz_fr_document = url_base.format(version='/fr/abc/index.html#document-xyz')
33-
self.pip_latest_document_url = url_base.format(version='/en/latest/document/')
29+
self.pip_abc_fr_url_index = url_base.format(version='/fr/abc/index.html')
30+
self.pip_abc_xyz_page_url = url_base.format(version='/en/abc/xyz')
31+
self.pip_abc_xyz_fr_page_url = url_base.format(version='/fr/abc/xyz')
32+
self.pip_latest_document_url = url_base.format(version='/en/latest/document')
3433
self.pip_latest_document_page_url = url_base.format(version='/en/latest/document.html')
3534

3635
with mock.patch('readthedocs.projects.models.broadcast'):
@@ -45,136 +44,40 @@ def test_project_only(self):
4544
url = core_tags.make_document_url(proj, '')
4645
self.assertEqual(url, self.pip_latest_url)
4746

48-
def test_project_only_htmldir(self):
49-
proj = Project.objects.get(slug='pip')
50-
proj.documentation_type = 'sphinx_htmldir'
51-
url = core_tags.make_document_url(proj)
52-
self.assertEqual(url, self.pip_latest_url)
53-
url = core_tags.make_document_url(proj, '')
54-
self.assertEqual(url, self.pip_latest_url)
55-
56-
def test_project_only_singlehtml(self):
57-
proj = Project.objects.get(slug='pip')
58-
proj.documentation_type = 'sphinx_singlehtml'
59-
url = core_tags.make_document_url(proj)
60-
self.assertEqual(url, self.pip_latest_url)
61-
url = core_tags.make_document_url(proj, '')
62-
self.assertEqual(url, self.pip_latest_url)
63-
6447
def test_translation_project_only(self):
6548
proj = Project.objects.get(slug='pip-fr')
6649
url = core_tags.make_document_url(proj)
6750
self.assertEqual(url, self.pip_latest_fr_url)
6851
url = core_tags.make_document_url(proj, '')
6952
self.assertEqual(url, self.pip_latest_fr_url)
7053

71-
def test_translation_project_only_htmldir(self):
72-
proj = Project.objects.get(slug='pip-fr')
73-
proj.documentation_type = 'sphinx_htmldir'
74-
url = core_tags.make_document_url(proj)
75-
self.assertEqual(url, self.pip_latest_fr_url)
76-
url = core_tags.make_document_url(proj, '')
77-
self.assertEqual(url, self.pip_latest_fr_url)
78-
79-
def test_translation_project_only_singlehtml(self):
80-
proj = Project.objects.get(slug='pip-fr')
81-
proj.documentation_type = 'sphinx_singlehtml'
82-
url = core_tags.make_document_url(proj)
83-
self.assertEqual(url, self.pip_latest_fr_url)
84-
url = core_tags.make_document_url(proj, '')
85-
self.assertEqual(url, self.pip_latest_fr_url)
86-
8754
def test_project_and_version(self):
8855
proj = Project.objects.get(slug='pip')
8956
url = core_tags.make_document_url(proj, 'abc')
9057
self.assertEqual(url, self.pip_abc_url)
9158
url = core_tags.make_document_url(proj, 'abc', '')
9259
self.assertEqual(url, self.pip_abc_url)
9360

94-
def test_project_and_version_htmldir(self):
95-
proj = Project.objects.get(slug='pip')
96-
proj.documentation_type = 'sphinx_htmldir'
97-
url = core_tags.make_document_url(proj, 'abc')
98-
self.assertEqual(url, self.pip_abc_url)
99-
url = core_tags.make_document_url(proj, 'abc', '')
100-
self.assertEqual(url, self.pip_abc_url)
101-
102-
def test_project_and_version_singlehtml(self):
103-
proj = Project.objects.get(slug='pip')
104-
proj.documentation_type = 'sphinx_singlehtml'
105-
url = core_tags.make_document_url(proj, 'abc')
106-
self.assertEqual(url, self.pip_abc_url)
107-
url = core_tags.make_document_url(proj, 'abc', '')
108-
self.assertEqual(url, self.pip_abc_url)
109-
11061
def test_translation_project_and_version(self):
11162
proj = Project.objects.get(slug='pip-fr')
11263
url = core_tags.make_document_url(proj, 'abc')
11364
self.assertEqual(url, self.pip_abc_fr_url)
11465
url = core_tags.make_document_url(proj, 'abc', '')
11566
self.assertEqual(url, self.pip_abc_fr_url)
11667

117-
def test_translation_project_and_version_htmldir(self):
118-
proj = Project.objects.get(slug='pip-fr')
119-
proj.documentation_type = 'sphinx_htmldir'
120-
url = core_tags.make_document_url(proj, 'abc')
121-
self.assertEqual(url, self.pip_abc_fr_url)
122-
url = core_tags.make_document_url(proj, 'abc', '')
123-
self.assertEqual(url, self.pip_abc_fr_url)
124-
125-
def test_translation_project_and_version_singlehtml(self):
126-
proj = Project.objects.get(slug='pip-fr')
127-
proj.documentation_type = 'sphinx_singlehtml'
128-
url = core_tags.make_document_url(proj, 'abc')
129-
self.assertEqual(url, self.pip_abc_fr_url)
130-
url = core_tags.make_document_url(proj, 'abc', '')
131-
self.assertEqual(url, self.pip_abc_fr_url)
132-
13368
def test_project_and_version_and_page(self):
13469
proj = Project.objects.get(slug='pip')
13570
url = core_tags.make_document_url(proj, 'abc', 'xyz')
13671
self.assertEqual(url, self.pip_abc_xyz_page_url)
137-
url = core_tags.make_document_url(proj, 'abc', 'index')
138-
self.assertEqual(url, self.pip_abc_url)
139-
140-
def test_project_and_version_and_page_htmldir(self):
141-
proj = Project.objects.get(slug='pip')
142-
proj.documentation_type = 'sphinx_htmldir'
143-
url = core_tags.make_document_url(proj, 'abc', 'xyz')
144-
self.assertEqual(url, self.pip_abc_xyz_dir_url)
145-
url = core_tags.make_document_url(proj, 'abc', 'index')
146-
self.assertEqual(url, self.pip_abc_url)
147-
148-
def test_project_and_version_and_page_signlehtml(self):
149-
proj = Project.objects.get(slug='pip')
150-
proj.documentation_type = 'sphinx_singlehtml'
151-
url = core_tags.make_document_url(proj, 'abc', 'xyz')
152-
self.assertEqual(url, self.pip_abc_xyz_document)
153-
url = core_tags.make_document_url(proj, 'abc', 'index')
154-
self.assertEqual(url, self.pip_abc_url)
72+
url = core_tags.make_document_url(proj, 'abc', 'index.html')
73+
self.assertEqual(url, self.pip_abc_url_index)
15574

15675
def test_translation_project_and_version_and_page(self):
15776
proj = Project.objects.get(slug='pip-fr')
15877
url = core_tags.make_document_url(proj, 'abc', 'xyz')
15978
self.assertEqual(url, self.pip_abc_xyz_fr_page_url)
160-
url = core_tags.make_document_url(proj, 'abc', 'index')
161-
self.assertEqual(url, self.pip_abc_fr_url)
162-
163-
def test_translation_project_and_version_and_page_htmldir(self):
164-
proj = Project.objects.get(slug='pip-fr')
165-
proj.documentation_type = 'sphinx_htmldir'
166-
url = core_tags.make_document_url(proj, 'abc', 'xyz')
167-
self.assertEqual(url, self.pip_abc_xyz_fr_dir_url)
168-
url = core_tags.make_document_url(proj, 'abc', 'index')
169-
self.assertEqual(url, self.pip_abc_fr_url)
170-
171-
def test_translation_project_and_version_and_page_singlehtml(self):
172-
proj = Project.objects.get(slug='pip-fr')
173-
proj.documentation_type = 'sphinx_singlehtml'
174-
url = core_tags.make_document_url(proj, 'abc', 'xyz')
175-
self.assertEqual(url, self.pip_abc_xyz_fr_document)
176-
url = core_tags.make_document_url(proj, 'abc', 'index')
177-
self.assertEqual(url, self.pip_abc_fr_url)
79+
url = core_tags.make_document_url(proj, 'abc', 'index.html')
80+
self.assertEqual(url, self.pip_abc_fr_url_index)
17881

17982
def test_mkdocs(self):
18083
proj = Project.objects.get(slug='pip')
@@ -188,17 +91,11 @@ def test_mkdocs_no_directory_urls(self):
18891
url = core_tags.make_document_url(proj, LATEST, 'document.html')
18992
self.assertEqual(url, self.pip_latest_document_page_url)
19093

191-
def test_mkdocs_index(self):
192-
proj = Project.objects.get(slug='pip')
193-
proj.documentation_type = 'mkdocs'
194-
url = core_tags.make_document_url(proj, LATEST, 'index')
195-
self.assertEqual(url, self.pip_latest_url)
196-
19794
def test_mkdocs_index_no_directory_urls(self):
19895
proj = Project.objects.get(slug='pip')
19996
proj.documentation_type = 'mkdocs'
20097
url = core_tags.make_document_url(proj, LATEST, 'index.html')
201-
self.assertEqual(url, self.pip_latest_url)
98+
self.assertEqual(url, self.pip_latest_url_index)
20299

203100
def test_restructured_text(self):
204101
value = '*test*'

‎readthedocs/rtd_tests/tests/test_redirects.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ def test_redirect_prefix_infinite(self):
169169
project=self.pip, redirect_type='prefix',
170170
from_url='/',
171171
)
172-
r = self.client.get('/redirect', HTTP_HOST='pip.readthedocs.org')
172+
r = self.client.get('/redirect.html', HTTP_HOST='pip.readthedocs.org')
173173
self.assertEqual(r.status_code, 302)
174174
self.assertEqual(
175175
r['Location'], 'http://pip.readthedocs.org/en/latest/redirect.html',
@@ -448,7 +448,7 @@ def test_http_filenames_return_themselves(self):
448448
def test_redirects_no_subdomain(self):
449449
self.assertEqual(
450450
self.redirect.get_full_path('index.html'),
451-
'/docs/read-the-docs/en/latest/',
451+
'/docs/read-the-docs/en/latest/index.html',
452452
)
453453

454454
@override_settings(

0 commit comments

Comments
 (0)