Skip to content

Commit 48168e7

Browse files
CM Lubinskiagjohnson
CM Lubinski
authored andcommitted
Reduce unused params.
In several cases, we can use the provided `request` rather than access `self` (which could make these functions easier to test in isolation). In others, the unused args could be folded into an unnamed kwarg param.
1 parent 1ba4f12 commit 48168e7

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

readthedocs/restapi/views/model_views.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def get_queryset(self):
4747
def valid_versions(self, request, **kwargs):
4848
"""Maintain state of versions that are wanted."""
4949
project = get_object_or_404(
50-
Project.objects.api(self.request.user), pk=kwargs['pk'])
50+
Project.objects.api(request.user), pk=kwargs['pk'])
5151
if not project.num_major or not project.num_minor or not project.num_point:
5252
return Response(
5353
{'error': 'Project does not support point version control'},
@@ -62,7 +62,7 @@ def valid_versions(self, request, **kwargs):
6262
})
6363

6464
@detail_route()
65-
def translations(self, request, pk, **kwargs):
65+
def translations(self, _, **__):
6666
translations = self.get_object().translations.all()
6767
return Response({
6868
'translations': ProjectSerializer(translations, many=True).data
@@ -71,7 +71,7 @@ def translations(self, request, pk, **kwargs):
7171
@detail_route()
7272
def subprojects(self, request, **kwargs):
7373
project = get_object_or_404(
74-
Project.objects.api(self.request.user), pk=kwargs['pk'])
74+
Project.objects.api(request.user), pk=kwargs['pk'])
7575
rels = project.subprojects.all()
7676
children = [rel.child for rel in rels]
7777
return Response({
@@ -81,7 +81,7 @@ def subprojects(self, request, **kwargs):
8181
@decorators.detail_route(permission_classes=[permissions.IsAdminUser])
8282
def token(self, request, **kwargs):
8383
project = get_object_or_404(
84-
Project.objects.api(self.request.user), pk=kwargs['pk'])
84+
Project.objects.api(request.user), pk=kwargs['pk'])
8585
token = GitHubService.get_token_for_project(project, force_local=True)
8686
return Response({
8787
'token': token
@@ -90,7 +90,7 @@ def token(self, request, **kwargs):
9090
@decorators.detail_route()
9191
def canonical_url(self, request, **kwargs):
9292
project = get_object_or_404(
93-
Project.objects.api(self.request.user), pk=kwargs['pk'])
93+
Project.objects.api(request.user), pk=kwargs['pk'])
9494
return Response({
9595
'url': project.get_docs_url()
9696
})
@@ -103,7 +103,7 @@ def sync_versions(self, request, **kwargs):
103103
Returns the identifiers for the versions that have been deleted.
104104
"""
105105
project = get_object_or_404(
106-
Project.objects.api(self.request.user), pk=kwargs['pk'])
106+
Project.objects.api(request.user), pk=kwargs['pk'])
107107

108108
# If the currently highest non-prerelease version is active, then make
109109
# the new latest version active as well.

0 commit comments

Comments
 (0)