Fix review feedback

diff --git a/readthedocs/builds/syncers.py b/readthedocs/builds/syncers.py
index 7b61bb6..3c8af91 100644
--- a/readthedocs/builds/syncers.py
+++ b/readthedocs/builds/syncers.py
@@ -140,8 +140,7 @@ class RemotePuller(object):
         )
         ret = os.system(sync_cmd)
         if ret != 0:
-            log.error("COPY ERROR to app servers. Return code: {}".format(ret))
-            log.error("COPY ERROR command run: {}".format(sync_cmd))
+            log.error("COPY ERROR to app servers. Command: [{}] Return: [{}]".format(sync_cmd, ret))

 class Syncer(SettingsOverrideObject):
diff --git a/readthedocs/core/utils/__init__.py b/readthedocs/core/utils/__init__.py
index 10d8656..fca8e13 100644
--- a/readthedocs/core/utils/__init__.py
+++ b/readthedocs/core/utils/__init__.py
@@ -30,7 +30,10 @@ def broadcast(type, task, args, kwargs=None, callback=None):  # pylint: disable=
     """
     Run a broadcast across our servers.

-    Returns the task results for each task that was run.
+    Returns a task group that can be checked for results.
+
+    `callback` should be a task signature that will be run once,
+    after all of the broadcast tasks have finished running.
     """
     assert type in ['web', 'app', 'build']
     if kwargs is None:
@@ -47,10 +50,8 @@ def broadcast(type, task, args, kwargs=None, callback=None):  # pylint: disable=
         tasks.append(task_sig)
     if callback:
         task_promise = chord(tasks)(callback).get()
-        log.debug('Sent Chord: {}'.format(locals()))
     else:
         task_promise = group(*tasks).apply_async()
-        log.debug('Sent Group: {}'.format(locals()))
     return task_promise

diff --git a/readthedocs/settings/dev.py b/readthedocs/settings/dev.py
index 8c39e12..e605f2c 100644
--- a/readthedocs/settings/dev.py
+++ b/readthedocs/settings/dev.py
@@ -56,7 +56,7 @@ class CommunityDevSettings(CommunityBaseSettings):
     def LOGGING(self):  # noqa - avoid pep8 N802
         logging = super(CommunityDevSettings, self).LOGGING
         logging['formatters']['default']['format'] = '[%(asctime)s] ' + self.LOG_FORMAT
-        logging['handlers']['console']['level'] = 'DEBUG'
+        # Remove double logging
         logging['loggers']['']['handlers'] = []
         return logging

Author: ericholscher

readthedocs/builds/syncers.py

@@ -140,8 +140,7 @@ def copy(cls, path, target, host, is_file=False, **__):
         )
         ret = os.system(sync_cmd)
         if ret != 0:
-            log.error("COPY ERROR to app servers. Return code: {}".format(ret))
-            log.error("COPY ERROR command run: {}".format(sync_cmd))
+            log.error("COPY ERROR to app servers. Command: [{}] Return: [{}]".format(sync_cmd, ret))
 
 
 class Syncer(SettingsOverrideObject):

readthedocs/core/utils/__init__.py

@@ -30,7 +30,10 @@ def broadcast(type, task, args, kwargs=None, callback=None):  # pylint: disable=
     """
     Run a broadcast across our servers.
 
-    Returns the task results for each task that was run.
+    Returns a task group that can be checked for results.
+
+    `callback` should be a task signature that will be run once,
+    after all of the broadcast tasks have finished running.
     """
     assert type in ['web', 'app', 'build']
     if kwargs is None:
@@ -47,10 +50,8 @@ def broadcast(type, task, args, kwargs=None, callback=None):  # pylint: disable=
         tasks.append(task_sig)
     if callback:
         task_promise = chord(tasks)(callback).get()
-        log.debug('Sent Chord: {}'.format(locals()))
     else:
         task_promise = group(*tasks).apply_async()
-        log.debug('Sent Group: {}'.format(locals()))
     return task_promise
 
 

readthedocs/settings/dev.py

@@ -56,7 +56,7 @@ def DATABASES(self):  # noqa
     def LOGGING(self):  # noqa - avoid pep8 N802
         logging = super(CommunityDevSettings, self).LOGGING
         logging['formatters']['default']['format'] = '[%(asctime)s] ' + self.LOG_FORMAT
-        logging['handlers']['console']['level'] = 'DEBUG'
+        # Remove double logging
         logging['loggers']['']['handlers'] = []
         return logging