Refactor test_builds to use explicit dynamic fixtures instead of factories

Author: gregmuellegger

readthedocs/rtd_tests/tests/test_builds.py

@@ -2,10 +2,12 @@
 import subprocess
 
 from django.test import TestCase
+from django_dynamic_fixture import get
+from django_dynamic_fixture import fixture
 import mock
 
+from readthedocs.projects.models import Project
 from readthedocs.projects.tasks import build_docs
-from readthedocs.rtd_tests.factories.projects_factories import ProjectFactory
 from readthedocs.rtd_tests.mocks.paths import fake_paths_lookup
 from readthedocs.doc_builder.loader import get_builder_class
 
@@ -46,7 +48,11 @@ def test_build(self, mock_Popen, mock_api_versions, mock_chdir, mock_apiv2_downl
         mock_Popen.return_value = mock_process
         mock_Popen.side_effect = build_subprocess_side_effect
 
-        project = ProjectFactory(allow_comments=True)
+        project = get(Project,
+                      slug='project-1',
+                      documentation_type='sphinx',
+                      conf_py_file='test_conf.py',
+                      versions=[fixture()])
 
         version = project.versions.all()[0]
         mock_api_versions.return_value = [version]
@@ -77,7 +83,10 @@ def test_build(self, mock_Popen, mock_api_versions, mock_chdir, mock_apiv2_downl
     def test_builder_comments(self):
 
         # Normal build
-        project = ProjectFactory(allow_comments=True)
+        project = get(Project,
+                      documentation_type='sphinx',
+                      allow_comments=True,
+                      versions=[fixture()])
         version = project.versions.all()[0]
         builder_class = get_builder_class(project.documentation_type)
         builder = builder_class(version)
@@ -86,7 +95,10 @@ def test_builder_comments(self):
     def test_builder_no_comments(self):
 
         # Normal build
-        project = ProjectFactory(allow_comments=False)
+        project = get(Project,
+                      documentation_type='sphinx',
+                      allow_comments=False,
+                      versions=[fixture()])
         version = project.versions.all()[0]
         builder_class = get_builder_class(project.documentation_type)
         builder = builder_class(version)
@@ -114,9 +126,13 @@ def test_build_respects_pdf_flag(self,
         mock_Popen.return_value = mock_process
         mock_Popen.side_effect = build_subprocess_side_effect
 
-        project = ProjectFactory(
-            enable_pdf_build=True,
-            enable_epub_build=False)
+        project = get(Project,
+                      slug='project-1',
+                      documentation_type='sphinx',
+                      conf_py_file='test_conf.py',
+                      enable_pdf_build=True,
+                      enable_epub_build=False,
+                      versions=[fixture()])
         version = project.versions.all()[0]
 
         conf_path = os.path.join(project.checkout_path(version.slug), project.conf_py_file)
@@ -158,9 +174,13 @@ def test_build_respects_epub_flag(self,
         mock_Popen.return_value = mock_process
         mock_Popen.side_effect = build_subprocess_side_effect
 
-        project = ProjectFactory(
-            enable_pdf_build=False,
-            enable_epub_build=True)
+        project = get(Project,
+                      slug='project-2',
+                      documentation_type='sphinx',
+                      conf_py_file='test_conf.py',
+                      enable_pdf_build=False,
+                      enable_epub_build=True,
+                      versions=[fixture()])
         version = project.versions.all()[0]
 
         conf_path = os.path.join(project.checkout_path(version.slug), project.conf_py_file)