Send email notifications when an unhandled exception happened

humitos · humitos · commit 41a05f70bb26 · 2018-10-01T16:53:41.000+02:00
diff --git a/readthedocs/projects/tasks.py b/readthedocs/projects/tasks.py
@@ -366,6 +366,9 @@ def run(self, pk, version_pk=None, build_pk=None, record=True,
                     )
                 )
                 self.setup_env.update_build(BUILD_STATE_FINISHED)
+
+            # Send notifications for unhandled errors
+            self.send_notifications()
             return False
         else:
             # No exceptions in the setup step, catch unhandled errors in the
@@ -391,6 +394,9 @@ def run(self, pk, version_pk=None, build_pk=None, record=True,
                         )
                     )
                     self.build_env.update_build(BUILD_STATE_FINISHED)
+
+                # Send notifications for unhandled errors
+                self.send_notifications()
                 return False
 
         return True

Original file line number	Diff line number	Diff line change
`@@ -366,6 +366,9 @@ def run(self, pk, version_pk=None, build_pk=None, record=True,`
`366`	`366`	`)`
`367`	`367`	`)`
`368`	`368`	`self.setup_env.update_build(BUILD_STATE_FINISHED)`
	`369`	`+`
	`370`	`+ # Send notifications for unhandled errors`
	`371`	`+ self.send_notifications()`
`369`	`372`	`return False`
`370`	`373`	`else:`
`371`	`374`	`# No exceptions in the setup step, catch unhandled errors in the`
`@@ -391,6 +394,9 @@ def run(self, pk, version_pk=None, build_pk=None, record=True,`
`391`	`394`	`)`
`392`	`395`	`)`
`393`	`396`	`self.build_env.update_build(BUILD_STATE_FINISHED)`
	`397`	`+`
	`398`	`+ # Send notifications for unhandled errors`
	`399`	`+ self.send_notifications()`
`394`	`400`	`return False`
`395`	`401`
`396`	`402`	`return True`