Hide "Protected" privacy level from users

Protected causes a lot of confusions to users. I'm hiding it for now
as a temporarily solution while we implement more Version states and
this behavior can be easily managed. See #5321

Author: humitos

docs/privacy.rst

@@ -2,7 +2,7 @@ Privacy Levels
 ==============
 
 Read the Docs supports 3 different privacy levels on 2 different objects;
-Public, Protected, Private on Projects and Versions.
+Public, Private on Projects and Versions.
 
 Understanding the Privacy Levels
 --------------------------------
@@ -12,8 +12,6 @@ Understanding the Privacy Levels
 +============+============+===========+===========+=============+
 | Private    | No         | No        | No        | Yes         |
 +------------+------------+-----------+-----------+-------------+
-| Protected  | Yes        | No        | No        | Yes         |
-+------------+------------+-----------+-----------+-------------+
 | Public     | Yes        | Yes       | Yes       | Yes         |
 +------------+------------+-----------+-----------+-------------+
 
@@ -27,18 +25,6 @@ Public
 This is the easiest and most obvious. It is also the default.
 It means that everything is available to be seen by everyone.
 
-Protected
-~~~~~~~~~
-
-Protected means that your object won't show up in Listing Pages,
-but Detail pages still work. For example, a Project that is Protected will
-not show on the homepage Recently Updated list, however,
-if you link directly to the project, you will get a 200 and the page will display.
-
-Protected Versions are similar, they won't show up in your version listings,
-but will be available once linked to.
-
-
 Private
 ~~~~~~~
 

readthedocs/projects/constants.py

@@ -80,7 +80,10 @@
 
 PRIVACY_CHOICES = (
     (PUBLIC, _('Public')),
-    (PROTECTED, _('Protected')),
+    # Remove Protected for now since it cause confusions to users.
+    # There is a better way to manage this by using Version states
+    # See: https://github.com/rtfd/readthedocs.org/issues/5321
+    # (PROTECTED, _('Protected')),
     (PRIVATE, _('Private')),
 )
 

readthedocs/projects/models.py

@@ -329,8 +329,7 @@ class Project(models.Model):
         choices=constants.PRIVACY_CHOICES,
         default=settings.DEFAULT_PRIVACY_LEVEL,
         help_text=_(
-            'Level of privacy that you want on the repository. '
-            'Protected means public but not in listings.',
+            'Level of privacy that you want on the repository.',
         ),
     )
     version_privacy_level = models.CharField(