Make json.dump compatible with py2 and py3

humitos · humitos · commit 3b2f538cc218 · 2017-12-27T20:53:45.000-05:00
diff --git a/readthedocs/doc_builder/python_environments.py b/readthedocs/doc_builder/python_environments.py
@@ -159,8 +159,11 @@ def save_environment_json(self):
                 'image': build_image,
             },
         }
+
         with open(self.environment_json_path(), 'w') as fpath:
-            json.dump(data, fpath)
+            # Compatibility for Py2 and Py3. ``io.TextIOWrapper`` expects
+            # unicode but ``json.dumps`` returns str in Py2.
+            fpath.write(unicode(json.dumps(data)))
 
 
 class Virtualenv(PythonEnvironment):
