Skip to content

Commit 3225c38

Browse files
committed
Profile: redirect to /accounts/edit/ view on successful edit
Closes #10404
1 parent e0c68b9 commit 3225c38

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

readthedocs/profiles/views.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,7 @@ def get_object(self):
6161

6262
def get_success_url(self):
6363
return reverse(
64-
'profiles_profile_detail',
65-
kwargs={'username': self.request.user.username},
64+
"profiles_profile_edit",
6665
)
6766

6867

readthedocs/rtd_tests/tests/test_profile_views.py

+7-6
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ def test_edit_profile(self):
3636
},
3737
)
3838
self.assertTrue(resp.status_code, 200)
39+
self.assertEqual(resp["Location"], "/accounts/edit/")
3940

4041
self.user.refresh_from_db()
4142
self.user.profile.refresh_from_db()
@@ -195,32 +196,32 @@ def test_list_security_logs(self):
195196
resp = self.client.get(reverse('profiles_security_log'))
196197
self.assertEqual(resp.status_code, 200)
197198
auditlogs = resp.context_data['object_list']
198-
self.assertQuerysetEqual(auditlogs, queryset)
199+
self.assertQuerySetEqual(auditlogs, queryset)
199200

200201
# Show logs filtered by project.
201202
resp = self.client.get(reverse('profiles_security_log') + '?project=project')
202203
self.assertEqual(resp.status_code, 200)
203204
auditlogs = resp.context_data["object_list"]
204-
self.assertQuerysetEqual(auditlogs, queryset.filter(log_project_slug="project"))
205+
self.assertQuerySetEqual(auditlogs, queryset.filter(log_project_slug="project"))
205206

206207
# Show logs filtered by IP.
207208
ip = "10.10.10.2"
208209
resp = self.client.get(reverse("profiles_security_log") + f"?ip={ip}")
209210
self.assertEqual(resp.status_code, 200)
210211
auditlogs = resp.context_data['object_list']
211-
self.assertQuerysetEqual(auditlogs, queryset.filter(ip=ip))
212+
self.assertQuerySetEqual(auditlogs, queryset.filter(ip=ip))
212213

213214
# Show logs filtered by action.
214215
resp = self.client.get(reverse('profiles_security_log') + '?action=authentication')
215216
self.assertEqual(resp.status_code, 200)
216217
auditlogs = resp.context_data['object_list']
217-
self.assertQuerysetEqual(auditlogs, queryset.filter(action=AuditLog.AUTHN))
218+
self.assertQuerySetEqual(auditlogs, queryset.filter(action=AuditLog.AUTHN))
218219

219220
# Show logs filtered by action.
220221
resp = self.client.get(reverse('profiles_security_log') + '?action=authentication-failure')
221222
self.assertEqual(resp.status_code, 200)
222223
auditlogs = resp.context_data["object_list"]
223-
self.assertQuerysetEqual(
224+
self.assertQuerySetEqual(
224225
auditlogs, queryset.filter(action=AuditLog.AUTHN_FAILURE)
225226
)
226227

@@ -235,7 +236,7 @@ def test_list_security_logs(self):
235236
resp = self.client.get(reverse('profiles_security_log') + '?action=invalid')
236237
self.assertEqual(resp.status_code, 200)
237238
auditlogs = resp.context_data['object_list']
238-
self.assertQuerysetEqual(auditlogs, queryset)
239+
self.assertQuerySetEqual(auditlogs, queryset)
239240

240241

241242
@override_settings(

0 commit comments

Comments
 (0)