Remove deprecated_ utils and notifications

They are not useful anymore since it's not possible to build without a config
file or using a config file v1.

Author: humitos

readthedocs/builds/models.py

@@ -60,7 +60,6 @@
     get_vcs_url,
 )
 from readthedocs.builds.version_slug import VersionSlugField
-from readthedocs.config import LATEST_CONFIGURATION_VERSION
 from readthedocs.core.utils import extract_valid_attributes_for_model, trigger_build
 from readthedocs.notifications.models import Notification
 from readthedocs.projects.constants import (
@@ -1104,36 +1103,6 @@ def can_rebuild(self):
     def external_version_name(self):
         return external_version_name(self)
 
-    def deprecated_config_used(self):
-        """
-        Check whether this particular build is using a deprecated config file.
-
-        When using v1 or not having a config file at all, it returns ``True``.
-        Returns ``False`` only when it has a config file and it is using v2.
-
-        Note we are using this to communicate deprecation of v1 file and not using a config file.
-        See https://github.com/readthedocs/readthedocs.org/issues/10342
-        """
-        if not self.config:
-            return True
-
-        return int(self.config.get("version", "1")) != LATEST_CONFIGURATION_VERSION
-
-    def deprecated_build_image_used(self):
-        """
-        Check whether this particular build is using the deprecated "build.image" config.
-
-        Note we are using this to communicate deprecation of "build.image".
-        See https://github.com/readthedocs/meta/discussions/48
-        """
-        if not self.config:
-            # Don't notify users without a config file.
-            # We hope they will migrate to `build.os` in the process of adding a `.readthedocs.yaml`
-            return False
-
-        build_config_key = self.config.get("build", {})
-        return "image" in build_config_key
-
     def reset(self):
         """
         Reset the build so it can be re-used when re-trying.

readthedocs/rtd_tests/tests/test_builds.py

@@ -248,24 +248,6 @@ def test_build_is_stale(self):
         self.assertTrue(build_two.is_stale)
         self.assertFalse(build_three.is_stale)
 
-    def test_deprecated_config_used(self):
-        now = timezone.now()
-
-        build = get(
-            Build,
-            project=self.project,
-            version=self.version,
-            date=now - datetime.timedelta(minutes=8),
-            state="finished",
-        )
-
-        self.assertTrue(build.deprecated_config_used())
-
-        build.config = {"version": 2}
-        build.save()
-
-        self.assertFalse(build.deprecated_config_used())
-
     def test_build_is_external(self):
         # Turn the build version to EXTERNAL type.
         self.version.type = EXTERNAL

readthedocs/templates/builds/build_detail.html

@@ -162,40 +162,6 @@
           </p>
         </div>
       {% endif %}
-
-     {% comment %}
-        NOTE: I'm not migrating "deprecated build image used" nor "deprecated config used"
-        since these notifications are not useful anymore.
-        The YAML config file is required now and it's not possible to use `build.image` anymore.
-        We should probably remove these blocks completely now.
-
-      {# This message is not dynamic and only appears when loading the page after the build has finished #}
-      {% if build.finished and build.deprecated_build_image_used %}
-      <div class="build-ideas">
-          <p>
-              {% blocktrans trimmed with config_file_link="https://blog.readthedocs.com/use-build-os-config/" %}
-              <strong>Your builds will stop working soon!</strong><br/>
-              "build.image" config key is deprecated and it will be removed soon.
-              <a href="{{ config_file_link }}">Read our blog post to know how to migrate to new key "build.os"</a>
-              and ensure your project continues building successfully.
-              {% endblocktrans %}
-          </p>
-      </div>
-      {% endif %}
-      {% if build.finished and build.deprecated_config_used %}
-      <div class="build-ideas">
-        <p>
-          {% blocktrans trimmed with config_file_link="https://blog.readthedocs.com/migrate-configuration-v2/" %}
-            <strong>Your builds will stop working soon!</strong><br/>
-            Configuration files will <strong>soon be required</strong> by projects, and will no longer be optional.
-            <a href="{{ config_file_link }}">Read our blog post to create one</a>
-            and ensure your project continues building successfully.
-          {% endblocktrans %}
-        </p>
-      </div>
-      {% endif %}
-    {% endcomment %}
-
     {% endif %}